Issue 589653002: Move RFH's WeakPtrFactory to be the last member.

Issue 589653002: Move RFH's WeakPtrFactory to be the last member. (Closed)

Created:
6 years, 3 months ago by Charlie Reis

Modified:
6 years, 3 months ago

Reviewers:
dmazzoni

CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Move RFH's WeakPtrFactory to be the last member. BUG=none Committed: https://crrev.com/2ea692ffc1f83dde364ece4fd608d8817825fc2b Cr-Commit-Position: refs/heads/master@{#295777}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	content/browser/frame_host/render_frame_host_impl.h	View		2 chunks	+3 lines, -2 lines	0 comments	Download

Total messages: 9 (3 generated)

Charlie Reis

Dominic, it looks like the later members were added in http://crrev.com/285767. Ok, if I move ...

6 years, 3 months ago (2014-09-19 18:38:33 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/589653002/1

6 years, 3 months ago (2014-09-19 19:20:17 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as c819a8e65c4d53b400253b5b26ad3ce0e0996ee3

6 years, 3 months ago (2014-09-19 21:10:49 UTC) #8

commit-bot: I haz the power

6 years, 3 months ago (2014-09-19 21:11:43 UTC) #9

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/2ea692ffc1f83dde364ece4fd608d8817825fc2b
Cr-Commit-Position: refs/heads/master@{#295777}