Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Side by Side Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 589653002: Move RFH's WeakPtrFactory to be the last member. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
7 7
8 #include <map> 8 #include <map>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 461 matching lines...) Expand 10 before | Expand all | Expand 10 after
472 // be one suspended navigation, because RenderFrameHostManager will destroy 472 // be one suspended navigation, because RenderFrameHostManager will destroy
473 // the pending RenderFrameHost and create a new one if a second navigation 473 // the pending RenderFrameHost and create a new one if a second navigation
474 // occurs. 474 // occurs.
475 scoped_ptr<FrameMsg_Navigate_Params> suspended_nav_params_; 475 scoped_ptr<FrameMsg_Navigate_Params> suspended_nav_params_;
476 476
477 // When the last BeforeUnload message was sent. 477 // When the last BeforeUnload message was sent.
478 base::TimeTicks send_before_unload_start_time_; 478 base::TimeTicks send_before_unload_start_time_;
479 479
480 ServiceRegistryImpl service_registry_; 480 ServiceRegistryImpl service_registry_;
481 481
482 base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_;
483
484 scoped_ptr<BrowserAccessibilityManager> browser_accessibility_manager_; 482 scoped_ptr<BrowserAccessibilityManager> browser_accessibility_manager_;
485 483
486 // Callback when an event is received, for testing. 484 // Callback when an event is received, for testing.
487 base::Callback<void(ui::AXEvent, int)> accessibility_testing_callback_; 485 base::Callback<void(ui::AXEvent, int)> accessibility_testing_callback_;
488 // The most recently received accessibility tree - for testing only. 486 // The most recently received accessibility tree - for testing only.
489 scoped_ptr<ui::AXTree> ax_tree_for_testing_; 487 scoped_ptr<ui::AXTree> ax_tree_for_testing_;
490 488
489 // NOTE: This must be the last member.
490 base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_;
491
491 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl); 492 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl);
492 }; 493 };
493 494
494 } // namespace content 495 } // namespace content
495 496
496 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 497 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698