IA2 role is not correct for input type attribute in button and checkbox state with menu as parent

IA2 role is not correct for input type attribute in button state and checkbox state with menu as parent.

According to specs, for input type attribute in button state with menu as parent, IA2 role should be ROLE_SYSTEM_MENUITEM and for input type attribute in checkbox state, IA2 role should be IA2_ROLE_CHECK_MENU_ITEM.

BUG=169574
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182827

[dmazzoni, 2014-09-26 15:59:18]

dmazzoni@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2014-09-26 15:59:20]

https://codereview.chromium.org/589383004/diff/20001/Source/core/accessibilit...
File Source/core/accessibility/AXNodeObject.cpp (right):

https://codereview.chromium.org/589383004/diff/20001/Source/core/accessibilit...
Source/core/accessibility/AXNodeObject.cpp:212: return MenuItemRole;
This doesn't look right.

Why not create a new role CheckboxMenuItem?

Then we can map that to the appropriate role depending on the platform.

[shreeramk, 2014-09-26 17:39:06]

On 2014/09/26 15:59:20, dmazzoni wrote:
>
https://codereview.chromium.org/589383004/diff/20001/Source/core/accessibilit...
> File Source/core/accessibility/AXNodeObject.cpp (right):
> 
>
https://codereview.chromium.org/589383004/diff/20001/Source/core/accessibilit...
> Source/core/accessibility/AXNodeObject.cpp:212: return MenuItemRole;
> This doesn't look right.
> 
> Why not create a new role CheckboxMenuItem?
> 
> Then we can map that to the appropriate role depending on the platform.

Yes. I also thought the same.

Actually, I asked that question here on the bug. http://crbug.com169574

[shreeramk, 2014-09-29 04:32:49]

PTAL!

Could you please tell me which spec do we need to follow for accessibility on
Android?

[dmazzoni, 2014-09-29 05:20:57]

On 2014/09/29 04:32:49, shreeram.k wrote:
> Could you please tell me which spec do we need to follow for accessibility on
> Android?

No spec, we're making it up as we go. You can see the possible attributes to
return here:

http://developer.android.com/reference/android/view/accessibility/Accessibili...

[dmazzoni, 2014-09-29 05:22:16]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2014-09-29 05:22:17]

lgtm

[commit-bot: I haz the power, 2014-09-29 05:23:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/589383004/60001

[shreeramk, 2014-09-29 05:25:43]

On 2014/09/29 05:23:00, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/589383004/60001

@Dominic:

I think I can use GetHtmlAttribute in chromium side to get the type attribute
value and make a check for the role. Then we don't have to introduce this new
extra Role in blink side. What you say?

I just verified that GetHtmlAttribute can be used.

[dmazzoni, 2014-09-29 05:30:08]

On 2014/09/29 05:25:43, shreeram.k wrote:
> On 2014/09/29 05:23:00, I haz the power (commit-bot) wrote:
> > CQ is trying da patch. Follow status at
> >  https://chromium-cq-status.appspot.com/patch-status/589383004/60001
> 
> @Dominic:
> 
> I think I can use GetHtmlAttribute in chromium side to get the type attribute
> value and make a check for the role. Then we don't have to introduce this new
> extra Role in blink side. What you say?

No, I'd prefer the extra role in Blink.

I'd like to eliminate all uses of GetHtmlAttribute in Chromium accessibility
code so we can stop keeping track of html attributes we don't actually need.

Thanks.

[commit-bot: I haz the power, 2014-09-29 09:53:04]

Committed patchset #4 (id:60001) as 182827