Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Unified Diff: Source/core/accessibility/AXRenderObject.cpp

Issue 589383004: IA2 role is not correct for input type attribute in button and checkbox state with menu as parent (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/accessibility/AXObject.h ('k') | Source/web/AssertMatchingEnums.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/accessibility/AXRenderObject.cpp
diff --git a/Source/core/accessibility/AXRenderObject.cpp b/Source/core/accessibility/AXRenderObject.cpp
index 872cd1eb066051384e7aa4c3dfb2691253f5a435..a88b835373972585b88ab757e5412c1aa5d3379f 100644
--- a/Source/core/accessibility/AXRenderObject.cpp
+++ b/Source/core/accessibility/AXRenderObject.cpp
@@ -313,8 +313,16 @@ AccessibilityRole AXRenderObject::determineAccessibilityRole()
if (isHTMLInputElement(node)) {
HTMLInputElement& input = toHTMLInputElement(*node);
const AtomicString& type = input.type();
- if (type == InputTypeNames::checkbox)
+ if (type == InputTypeNames::button) {
+ if (node->parentElement() && isHTMLMenuElement(node->parentElement()))
+ return MenuItemRole;
+ return buttonRoleType();
+ }
+ if (type == InputTypeNames::checkbox) {
+ if (node->parentElement() && isHTMLMenuElement(node->parentElement()))
+ return CheckBoxMenuItemRole;
return CheckBoxRole;
+ }
if (type == InputTypeNames::radio)
return RadioButtonRole;
if (input.isTextButton())
« no previous file with comments | « Source/core/accessibility/AXObject.h ('k') | Source/web/AssertMatchingEnums.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698