Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 589353003: Revert "Allow editing passwords in settings/passwords" (Closed)

Created:
6 years, 3 months ago by vabr (Chromium)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, gcasto+watchlist_chromium.org, arv+watch_chromium.org, mkwst+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert "Allow editing passwords in settings/passwords" This reverts commit 41c3d488906019eb4cec3b43ad39e67e9ee9b92c, CL https://codereview.chromium.org/489103004. The above change caused a couple of UI issues, as well as internationalization troubles (http://crbug.com/377410#c10). We should land it again after all the fixes get incorporated. BUG=416754, 416818, 416825, 416757, 377410 TBR=engedy@chromium.org,pkasting@chromium.org,btapiz@gmail.com,danbeam@chromium.org Committed: https://crrev.com/7ffaaeeb7ce0baff9fe8ddb110ea939fe69d8428 Cr-Commit-Position: refs/heads/master@{#296180}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -730 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -18 lines 0 comments Download
M chrome/browser/resources/options/password_manager.js View 6 chunks +2 lines, -61 lines 0 comments Download
M chrome/browser/resources/options/password_manager_list.css View 3 chunks +8 lines, -19 lines 0 comments Download
M chrome/browser/resources/options/password_manager_list.js View 13 chunks +67 lines, -346 lines 0 comments Download
M chrome/browser/ui/passwords/password_manager_presenter.h View 3 chunks +4 lines, -20 lines 0 comments Download
M chrome/browser/ui/passwords/password_manager_presenter.cc View 2 chunks +0 lines, -71 lines 0 comments Download
M chrome/browser/ui/passwords/password_manager_presenter_unittest.cc View 6 chunks +10 lines, -122 lines 0 comments Download
M chrome/browser/ui/webui/options/password_manager_handler.h View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/browser/ui/webui/options/password_manager_handler.cc View 3 chunks +0 lines, -62 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/589353003/1
6 years, 3 months ago (2014-09-23 13:19:37 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as e22286bf1a139b2bc10cbd8afb5df530af503b27
6 years, 3 months ago (2014-09-23 14:31:23 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 14:32:22 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7ffaaeeb7ce0baff9fe8ddb110ea939fe69d8428
Cr-Commit-Position: refs/heads/master@{#296180}

Powered by Google App Engine
This is Rietveld 408576698