Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Side by Side Diff: chrome/browser/ui/webui/options/password_manager_handler.cc

Issue 589353003: Revert "Allow editing passwords in settings/passwords" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/webui/options/password_manager_handler.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/options/password_manager_handler.h" 5 #include "chrome/browser/ui/webui/options/password_manager_handler.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/prefs/pref_service.h" 8 #include "base/prefs/pref_service.h"
9 #include "base/strings/string_number_conversions.h" 9 #include "base/strings/string_number_conversions.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 base::DictionaryValue* localized_strings) { 46 base::DictionaryValue* localized_strings) {
47 DCHECK(localized_strings); 47 DCHECK(localized_strings);
48 48
49 static const OptionsStringResource resources[] = { 49 static const OptionsStringResource resources[] = {
50 { "savedPasswordsTitle", 50 { "savedPasswordsTitle",
51 IDS_PASSWORDS_SHOW_PASSWORDS_TAB_TITLE }, 51 IDS_PASSWORDS_SHOW_PASSWORDS_TAB_TITLE },
52 { "passwordExceptionsTitle", 52 { "passwordExceptionsTitle",
53 IDS_PASSWORDS_EXCEPTIONS_TAB_TITLE }, 53 IDS_PASSWORDS_EXCEPTIONS_TAB_TITLE },
54 { "passwordSearchPlaceholder", 54 { "passwordSearchPlaceholder",
55 IDS_PASSWORDS_PAGE_SEARCH_PASSWORDS }, 55 IDS_PASSWORDS_PAGE_SEARCH_PASSWORDS },
56 { "newPasswordUrlFieldPlaceholder",
57 IDS_PASSWORDS_PAGE_URL_INSTRUCTION },
58 { "newPasswordUsernameFieldPlaceholder",
59 IDS_PASSWORDS_PAGE_USERNAME_INSTRUCTION },
60 { "newPasswordPasswordFieldPlaceholder",
61 IDS_PASSWORDS_PAGE_PASSWORD_INSTRUCTION },
62 { "editPasswordInvalidUrlTooltip",
63 IDS_PASSWORDS_PAGE_INVALID_URL_TOOLTIP },
64 { "editPasswordInvalidPasswordTooltip",
65 IDS_PASSWORDS_PAGE_INVALID_PASSWORD_TOOLTIP },
66 { "passwordShowButton", 56 { "passwordShowButton",
67 IDS_PASSWORDS_PAGE_VIEW_SHOW_BUTTON }, 57 IDS_PASSWORDS_PAGE_VIEW_SHOW_BUTTON },
68 { "passwordHideButton", 58 { "passwordHideButton",
69 IDS_PASSWORDS_PAGE_VIEW_HIDE_BUTTON }, 59 IDS_PASSWORDS_PAGE_VIEW_HIDE_BUTTON },
70 { "passwordOverwriteButton",
71 IDS_PASSWORDS_PAGE_VIEW_OVERWRITE_BUTTON },
72 { "passwordsNoPasswordsDescription", 60 { "passwordsNoPasswordsDescription",
73 IDS_PASSWORDS_PAGE_VIEW_NO_PASSWORDS_DESCRIPTION }, 61 IDS_PASSWORDS_PAGE_VIEW_NO_PASSWORDS_DESCRIPTION },
74 { "passwordsNoExceptionsDescription", 62 { "passwordsNoExceptionsDescription",
75 IDS_PASSWORDS_PAGE_VIEW_NO_EXCEPTIONS_DESCRIPTION }, 63 IDS_PASSWORDS_PAGE_VIEW_NO_EXCEPTIONS_DESCRIPTION },
76 }; 64 };
77 65
78 RegisterStrings(localized_strings, resources, arraysize(resources)); 66 RegisterStrings(localized_strings, resources, arraysize(resources));
79 RegisterTitle(localized_strings, "passwordsPage", 67 RegisterTitle(localized_strings, "passwordsPage",
80 IDS_PASSWORDS_EXCEPTIONS_WINDOW_TITLE); 68 IDS_PASSWORDS_EXCEPTIONS_WINDOW_TITLE);
81 69
(...skipping 12 matching lines...) Expand all
94 82
95 localized_strings->SetBoolean("disableShowPasswords", disable_show_passwords); 83 localized_strings->SetBoolean("disableShowPasswords", disable_show_passwords);
96 } 84 }
97 85
98 void PasswordManagerHandler::RegisterMessages() { 86 void PasswordManagerHandler::RegisterMessages() {
99 web_ui()->RegisterMessageCallback( 87 web_ui()->RegisterMessageCallback(
100 "updatePasswordLists", 88 "updatePasswordLists",
101 base::Bind(&PasswordManagerHandler::HandleUpdatePasswordLists, 89 base::Bind(&PasswordManagerHandler::HandleUpdatePasswordLists,
102 base::Unretained(this))); 90 base::Unretained(this)));
103 web_ui()->RegisterMessageCallback( 91 web_ui()->RegisterMessageCallback(
104 "checkOriginValidityForAdding",
105 base::Bind(&PasswordManagerHandler::HandleCheckOriginValidityForAdding,
106 base::Unretained(this)));
107 web_ui()->RegisterMessageCallback(
108 "addPassword",
109 base::Bind(&PasswordManagerHandler::HandleAddPassword,
110 base::Unretained(this)));
111 web_ui()->RegisterMessageCallback(
112 "updatePassword",
113 base::Bind(&PasswordManagerHandler::HandleUpdatePassword,
114 base::Unretained(this)));
115 web_ui()->RegisterMessageCallback(
116 "removeSavedPassword", 92 "removeSavedPassword",
117 base::Bind(&PasswordManagerHandler::HandleRemoveSavedPassword, 93 base::Bind(&PasswordManagerHandler::HandleRemoveSavedPassword,
118 base::Unretained(this))); 94 base::Unretained(this)));
119 web_ui()->RegisterMessageCallback( 95 web_ui()->RegisterMessageCallback(
120 "removePasswordException", 96 "removePasswordException",
121 base::Bind(&PasswordManagerHandler::HandleRemovePasswordException, 97 base::Bind(&PasswordManagerHandler::HandleRemovePasswordException,
122 base::Unretained(this))); 98 base::Unretained(this)));
123 web_ui()->RegisterMessageCallback( 99 web_ui()->RegisterMessageCallback(
124 "requestShowPassword", 100 "requestShowPassword",
125 base::Bind(&PasswordManagerHandler::HandleRequestShowPassword, 101 base::Bind(&PasswordManagerHandler::HandleRequestShowPassword,
126 base::Unretained(this))); 102 base::Unretained(this)));
127 } 103 }
128 104
129 void PasswordManagerHandler::InitializeHandler() { 105 void PasswordManagerHandler::InitializeHandler() {
130 password_manager_presenter_.Initialize(); 106 password_manager_presenter_.Initialize();
131 } 107 }
132 108
133 void PasswordManagerHandler::HandleCheckOriginValidityForAdding(
134 const base::ListValue* args) {
135 std::string origin;
136 const bool success = args->GetString(0, &origin);
137 DCHECK(success); // Don't CHECK here since the renderer might be compromised.
138 web_ui()->CallJavascriptFunction(
139 "PasswordManager.originValidityCheckComplete",
140 base::StringValue(origin),
141 base::FundamentalValue(
142 PasswordManagerPresenter::CheckOriginValidityForAdding(
143 GURL(origin))));
144 }
145
146 void PasswordManagerHandler::HandleAddPassword(const base::ListValue* args) {
147 std::string origin;
148 base::string16 username_value;
149 base::string16 password_value;
150 if (!args->GetString(0, &origin) || !args->GetString(1, &username_value) ||
151 !args->GetString(2, &password_value)) {
152 NOTREACHED();
153 return;
154 }
155 password_manager_presenter_.AddPassword(GURL(origin), username_value,
156 password_value);
157 }
158
159 void PasswordManagerHandler::HandleUpdatePassword(const base::ListValue* args) {
160 int index;
161 base::string16 password_value;
162 if (!ExtractIntegerValue(args, &index) || index < 0 ||
163 !args->GetString(1, &password_value)) {
164 NOTREACHED();
165 return;
166 }
167 password_manager_presenter_.UpdatePassword(static_cast<size_t>(index),
168 password_value);
169 }
170
171 void PasswordManagerHandler::HandleRemoveSavedPassword( 109 void PasswordManagerHandler::HandleRemoveSavedPassword(
172 const base::ListValue* args) { 110 const base::ListValue* args) {
173 std::string string_value = base::UTF16ToUTF8(ExtractStringValue(args)); 111 std::string string_value = base::UTF16ToUTF8(ExtractStringValue(args));
174 int index; 112 int index;
175 if (base::StringToInt(string_value, &index) && index >= 0) { 113 if (base::StringToInt(string_value, &index) && index >= 0) {
176 password_manager_presenter_.RemoveSavedPassword(static_cast<size_t>(index)); 114 password_manager_presenter_.RemoveSavedPassword(static_cast<size_t>(index));
177 } 115 }
178 } 116 }
179 117
180 void PasswordManagerHandler::HandleRemovePasswordException( 118 void PasswordManagerHandler::HandleRemovePasswordException(
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
242 for (size_t i = 0; i < password_exception_list.size(); ++i) { 180 for (size_t i = 0; i < password_exception_list.size(); ++i) {
243 entries.Append(new base::StringValue( 181 entries.Append(new base::StringValue(
244 net::FormatUrl(password_exception_list[i]->origin, languages_))); 182 net::FormatUrl(password_exception_list[i]->origin, languages_)));
245 } 183 }
246 184
247 web_ui()->CallJavascriptFunction("PasswordManager.setPasswordExceptionsList", 185 web_ui()->CallJavascriptFunction("PasswordManager.setPasswordExceptionsList",
248 entries); 186 entries);
249 } 187 }
250 188
251 } // namespace options 189 } // namespace options
OLDNEW
« no previous file with comments | « chrome/browser/ui/webui/options/password_manager_handler.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698