Move painting code from RenderView to ViewPainter.

Move painting code from RenderView to ViewPainter.

BUG=412088
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182463

[chrishtr, 2014-09-22 22:39:48]

chrishtr@chromium.org changed reviewers:
+ pdr@chromium.org

[chrishtr, 2014-09-22 22:39:49]

https://codereview.chromium.org/589283002/diff/1/Source/core/paint/BlockPaint...
File Source/core/paint/BlockPainter.h (left):

https://codereview.chromium.org/589283002/diff/1/Source/core/paint/BlockPaint...
Source/core/paint/BlockPainter.h:8: #include "core/rendering/RenderBlock.h"
Just some include dependency cleanup.

[pdr., 2014-09-22 22:49:17]

LGTM

https://codereview.chromium.org/589283002/diff/1/Source/core/paint/ViewPainte...
File Source/core/paint/ViewPainter.cpp (right):

https://codereview.chromium.org/589283002/diff/1/Source/core/paint/ViewPainte...
Source/core/paint/ViewPainter.cpp:19: ASSERT(!needsLayout());
We can move this up, or remove it entirely.

[chrishtr, 2014-09-22 23:10:52]

https://codereview.chromium.org/589283002/diff/1/Source/core/paint/ViewPainte...
File Source/core/paint/ViewPainter.cpp (right):

https://codereview.chromium.org/589283002/diff/1/Source/core/paint/ViewPainte...
Source/core/paint/ViewPainter.cpp:19: ASSERT(!needsLayout());
On 2014/09/22 22:49:17, pdr wrote:
> We can move this up, or remove it entirely.

Done.

[pdr., 2014-09-22 23:12:56]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2014-09-22 23:13:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/589283002/20001

[commit-bot: I haz the power, 2014-09-23 00:18:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-23 00:18:28]

Failed to apply patch for Source/core/core.gypi:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/core.gypi
  Hunk #1 FAILED at 1492.
  1 out of 1 hunk FAILED -- saving rejects to file Source/core/core.gypi.rej

Patch:       Source/core/core.gypi
Index: Source/core/core.gypi
diff --git a/Source/core/core.gypi b/Source/core/core.gypi
index
72a8dd6bc20563420486749be6a0d7d36e042d2a..ca1c9b48ee53fe2584920bcb4b43aa94b559ad72
100644
--- a/Source/core/core.gypi
+++ b/Source/core/core.gypi
@@ -1492,18 +1492,20 @@
             'paint/BoxPainter.h',
             'paint/BackgroundImageGeometry.h',
             'paint/BackgroundImageGeometry.cpp',
-            'paint/InlinePainter.h',
             'paint/InlinePainter.cpp',
-            'paint/LineBoxListPainter.h',
+            'paint/InlinePainter.h',
             'paint/LineBoxListPainter.cpp',
-            'paint/ObjectPainter.h',
+            'paint/LineBoxListPainter.h',
             'paint/ObjectPainter.cpp',
-            'paint/TablePainter.h',
+            'paint/ObjectPainter.h',
             'paint/TablePainter.cpp',
-            'paint/TableRowPainter.h',
+            'paint/TablePainter.h',
             'paint/TableRowPainter.cpp',
-            'paint/TableSectionPainter.h',
+            'paint/TableRowPainter.h',
             'paint/TableSectionPainter.cpp',
+            'paint/TableSectionPainter.h',
+            'paint/ViewPainter.cpp',
+            'paint/ViewPainter.h',
             'plugins/DOMMimeType.cpp',
             'plugins/DOMMimeType.h',
             'plugins/DOMMimeTypeArray.cpp',

[chrishtr, 2014-09-23 00:27:14]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2014-09-23 00:28:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/589283002/20001

[commit-bot: I haz the power, 2014-09-23 00:28:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-23 00:28:29]

Failed to apply patch for Source/core/core.gypi:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/core.gypi
  Hunk #1 FAILED at 1492.
  1 out of 1 hunk FAILED -- saving rejects to file Source/core/core.gypi.rej

Patch:       Source/core/core.gypi
Index: Source/core/core.gypi
diff --git a/Source/core/core.gypi b/Source/core/core.gypi
index
72a8dd6bc20563420486749be6a0d7d36e042d2a..ca1c9b48ee53fe2584920bcb4b43aa94b559ad72
100644
--- a/Source/core/core.gypi
+++ b/Source/core/core.gypi
@@ -1492,18 +1492,20 @@
             'paint/BoxPainter.h',
             'paint/BackgroundImageGeometry.h',
             'paint/BackgroundImageGeometry.cpp',
-            'paint/InlinePainter.h',
             'paint/InlinePainter.cpp',
-            'paint/LineBoxListPainter.h',
+            'paint/InlinePainter.h',
             'paint/LineBoxListPainter.cpp',
-            'paint/ObjectPainter.h',
+            'paint/LineBoxListPainter.h',
             'paint/ObjectPainter.cpp',
-            'paint/TablePainter.h',
+            'paint/ObjectPainter.h',
             'paint/TablePainter.cpp',
-            'paint/TableRowPainter.h',
+            'paint/TablePainter.h',
             'paint/TableRowPainter.cpp',
-            'paint/TableSectionPainter.h',
+            'paint/TableRowPainter.h',
             'paint/TableSectionPainter.cpp',
+            'paint/TableSectionPainter.h',
+            'paint/ViewPainter.cpp',
+            'paint/ViewPainter.h',
             'plugins/DOMMimeType.cpp',
             'plugins/DOMMimeType.h',
             'plugins/DOMMimeTypeArray.cpp',

[chrishtr, 2014-09-23 00:30:32]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2014-09-23 00:31:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/589283002/40001

[commit-bot: I haz the power, 2014-09-23 00:43:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-23 00:43:33]

Try jobs failed on following builders:
  mac_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/28280)

[chrishtr, 2014-09-23 01:31:53]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2014-09-23 01:32:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/589283002/60001

[commit-bot: I haz the power, 2014-09-23 03:25:52]

Committed patchset #4 (id:60001) as 182463