Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Unified Diff: chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

Issue 589263002: [Mac] Allow using the arrow keys for tabbing in the avatar bubble. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
diff --git a/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm b/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
index 9771594584064c805c2470ec3c804bb4595d55aa..152df725f2f1f048bde7f23ae248a7bde1914adb 100644
--- a/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
+++ b/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
@@ -1042,6 +1042,14 @@ class ActiveProfileObserverBridge : public AvatarMenuObserver,
[super windowWillClose:notification];
}
+- (void)moveDown:(id)sender {
+ [[self window] selectNextKeyView:[[self window] contentView]];
groby-ooo-7-16 2014/09/22 21:57:14 Can you keep the sender to just self?
noms (inactive) 2014/09/23 13:45:34 What do you mean? Do nothing if sender != self?
groby-ooo-7-16 2014/09/23 20:58:09 No, just [[self window] selectNextKeyView:self];
noms (inactive) 2014/09/23 21:26:12 Oh, right. I think I had initially tried just [sel
+}
+
+- (void)moveUp:(id)sender {
+ [[self window] selectPreviousKeyView:[[self window] contentView]];
+}
+
- (void)cleanUpEmbeddedViewContents {
webContents_.reset();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698