Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Side by Side Diff: chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

Issue 589263002: [Mac] Allow using the arrow keys for tabbing in the avatar bubble. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import <Cocoa/Cocoa.h> 5 #import <Cocoa/Cocoa.h>
6 6
7 #import "chrome/browser/ui/cocoa/profiles/profile_chooser_controller.h" 7 #import "chrome/browser/ui/cocoa/profiles/profile_chooser_controller.h"
8 8
9 #include "base/mac/bundle_locations.h" 9 #include "base/mac/bundle_locations.h"
10 #include "base/prefs/pref_service.h" 10 #include "base/prefs/pref_service.h"
(...skipping 1024 matching lines...) Expand 10 before | Expand all | Expand 10 after
1035 1035
1036 - (void)windowWillClose:(NSNotification*)notification { 1036 - (void)windowWillClose:(NSNotification*)notification {
1037 if (tutorialMode_ == profiles::TUTORIAL_MODE_CONFIRM_SIGNIN) { 1037 if (tutorialMode_ == profiles::TUTORIAL_MODE_CONFIRM_SIGNIN) {
1038 LoginUIServiceFactory::GetForProfile(browser_->profile())-> 1038 LoginUIServiceFactory::GetForProfile(browser_->profile())->
1039 SyncConfirmationUIClosed(false); 1039 SyncConfirmationUIClosed(false);
1040 } 1040 }
1041 1041
1042 [super windowWillClose:notification]; 1042 [super windowWillClose:notification];
1043 } 1043 }
1044 1044
1045 - (void)moveDown:(id)sender {
1046 [[self window] selectNextKeyView:[[self window] contentView]];
groby-ooo-7-16 2014/09/22 21:57:14 Can you keep the sender to just self?
noms (inactive) 2014/09/23 13:45:34 What do you mean? Do nothing if sender != self?
groby-ooo-7-16 2014/09/23 20:58:09 No, just [[self window] selectNextKeyView:self];
noms (inactive) 2014/09/23 21:26:12 Oh, right. I think I had initially tried just [sel
1047 }
1048
1049 - (void)moveUp:(id)sender {
1050 [[self window] selectPreviousKeyView:[[self window] contentView]];
1051 }
1052
1045 - (void)cleanUpEmbeddedViewContents { 1053 - (void)cleanUpEmbeddedViewContents {
1046 webContents_.reset(); 1054 webContents_.reset();
1047 } 1055 }
1048 1056
1049 - (id)initWithBrowser:(Browser*)browser 1057 - (id)initWithBrowser:(Browser*)browser
1050 anchoredAt:(NSPoint)point 1058 anchoredAt:(NSPoint)point
1051 viewMode:(profiles::BubbleViewMode)viewMode 1059 viewMode:(profiles::BubbleViewMode)viewMode
1052 tutorialMode:(profiles::TutorialMode)tutorialMode 1060 tutorialMode:(profiles::TutorialMode)tutorialMode
1053 serviceType:(signin::GAIAServiceType)serviceType { 1061 serviceType:(signin::GAIAServiceType)serviceType {
1054 base::scoped_nsobject<InfoBubbleWindow> window([[InfoBubbleWindow alloc] 1062 base::scoped_nsobject<InfoBubbleWindow> window([[InfoBubbleWindow alloc]
(...skipping 1122 matching lines...) Expand 10 before | Expand all | Expand 10 after
2177 } 2185 }
2178 2186
2179 - (bool)shouldShowGoIncognito { 2187 - (bool)shouldShowGoIncognito {
2180 bool incognitoAvailable = 2188 bool incognitoAvailable =
2181 IncognitoModePrefs::GetAvailability(browser_->profile()->GetPrefs()) != 2189 IncognitoModePrefs::GetAvailability(browser_->profile()->GetPrefs()) !=
2182 IncognitoModePrefs::DISABLED; 2190 IncognitoModePrefs::DISABLED;
2183 return incognitoAvailable && !browser_->profile()->IsGuestSession(); 2191 return incognitoAvailable && !browser_->profile()->IsGuestSession();
2184 } 2192 }
2185 2193
2186 @end 2194 @end
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698