[Mac] Allow using the arrow keys for tabbing in the avatar bubble.

[Mac] Allow using the arrow keys for tabbing in the avatar bubble.

BUG=414794
Committed: https://crrev.com/486805cdd18a55efdff5eb081642abe4de580b31
Cr-Commit-Position: refs/heads/master@{#296288}

[noms (inactive), 2014-09-22 21:38:27]

noms@chromium.org changed reviewers:
+ groby@chromium.org

[noms (inactive), 2014-09-22 21:38:27]

Hi Rachel,

We've decided to allow users to use up/down arrows to tab between items because
that's what they're used to from the old avatar bubble. Please take a look!

[groby-ooo-7-16, 2014-09-22 21:57:14]

I'm confused - my current profile chooser lets me go between profiles using
left/right just fine. What exactly is up/down used for?

https://codereview.chromium.org/589263002/diff/1/chrome/browser/ui/cocoa/prof...
File chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm (right):

https://codereview.chromium.org/589263002/diff/1/chrome/browser/ui/cocoa/prof...
chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm:1046: [[self
window] selectNextKeyView:[[self window] contentView]];
Can you keep the sender to just self?

[noms (inactive), 2014-09-22 22:13:26]

I think you're looking at the user manager. This is for the avatar bubble
(poorly named as a profile chooser because it has changed intention since its
birth), which is what shows up when you press the avatar button that has your
name.

[groby-ooo-7-16, 2014-09-22 22:14:15]

LGTM % nit, then

[noms (inactive), 2014-09-23 13:45:34]

https://codereview.chromium.org/589263002/diff/1/chrome/browser/ui/cocoa/prof...
File chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm (right):

https://codereview.chromium.org/589263002/diff/1/chrome/browser/ui/cocoa/prof...
chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm:1046: [[self
window] selectNextKeyView:[[self window] contentView]];
What do you mean? Do nothing if sender != self? 

On 2014/09/22 21:57:14, groby wrote:
> Can you keep the sender to just self?

[groby-ooo-7-16, 2014-09-23 20:58:09]

https://codereview.chromium.org/589263002/diff/1/chrome/browser/ui/cocoa/prof...
File chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm (right):

https://codereview.chromium.org/589263002/diff/1/chrome/browser/ui/cocoa/prof...
chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm:1046: [[self
window] selectNextKeyView:[[self window] contentView]];
On 2014/09/23 13:45:34, Monica Dinculescu wrote:
> What do you mean? Do nothing if sender != self? 
> 
> On 2014/09/22 21:57:14, groby wrote:
> > Can you keep the sender to just self?
> 

No, just
[[self window] selectNextKeyView:self];

[noms (inactive), 2014-09-23 21:26:12]

https://codereview.chromium.org/589263002/diff/1/chrome/browser/ui/cocoa/prof...
File chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm (right):

https://codereview.chromium.org/589263002/diff/1/chrome/browser/ui/cocoa/prof...
chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm:1046: [[self
window] selectNextKeyView:[[self window] contentView]];
On 2014/09/23 20:58:09, groby wrote:
> On 2014/09/23 13:45:34, Monica Dinculescu wrote:
> > What do you mean? Do nothing if sender != self? 
> > 
> > On 2014/09/22 21:57:14, groby wrote:
> > > Can you keep the sender to just self?
> > 
> 
> No, just
> [[self window] selectNextKeyView:self];
> 

Oh, right. I think I had initially tried just [self window] and that didn't
work. Done!

[noms (inactive), 2014-09-23 21:26:18]

The CQ bit was checked by noms@chromium.org

[commit-bot: I haz the power, 2014-09-23 21:27:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/589263002/20001

[commit-bot: I haz the power, 2014-09-23 22:46:28]

Committed patchset #2 (id:20001) as 36322ec6bf24f2301bdd4eccac021c5757c68fe2

[commit-bot: I haz the power, 2014-09-23 22:47:05]

Patchset 2 (id:??) landed as
https://crrev.com/486805cdd18a55efdff5eb081642abe4de580b31
Cr-Commit-Position: refs/heads/master@{#296288}