Issue 589043004: Restrict the number of cases where we force the compositor to do a synchronous paint to resizing an…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 589043004: Restrict the number of cases where we force the compositor to do a synchronous paint to resizing an… (Closed)

Created:
6 years, 3 months ago by ananta

Modified:
6 years, 3 months ago

Reviewers:
cpu_(ooo_6.6-7.5), sky

CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2125

Project:
chromium

Visibility:
Public.

More Reviews

Description

Restrict the number of cases where we force the compositor to do a synchronous paint to resizing and restore/maximize operations. Forcing the compositor to do a synchronous paint in window size changed notifications sends over a synchronous IPC to the GPU process which blocks the UI thread. We have been seeing cases where Chrome seems to freeze while performing operations like typing in the omnibox, etc. BUG=397633 R=sky,cpu Review URL: https://codereview.chromium.org/528173002 Cr-Commit-Position: refs/heads/master@{#293223} (cherry picked from commit b8729366a6d05e96f6283b077e500b1d882abfe7) Committed: https://chromium.googlesource.com/chromium/src/+/771e5c153c710f15351cb0e368cbb2c394420118

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -2 lines)			Patch
	M	ui/views/widget/desktop_aura/desktop_window_tree_host_win.h	View		1 chunk	+8 lines, -0 lines	0 comments	Download
	M	ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc	View		4 chunks	+33 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 771e5c1.

Expand Messages | Collapse Messages