Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 528173002: Restrict the number of cases where we force the compositor to do a synchronous paint to resizing an… (Closed)

Created:
6 years, 3 months ago by ananta
Modified:
6 years, 3 months ago
Reviewers:
cpu_(ooo_6.6-7.5), sky
CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Restrict the number of cases where we force the compositor to do a synchronous paint to resizing and restore/maximize operations. Forcing the compositor to do a synchronous paint in window size changed notifications sends over a synchronous IPC to the GPU process which blocks the UI thread. We have been seeing cases where Chrome seems to freeze while performing operations like typing in the omnibox, etc. BUG=397633 R=sky,cpu Committed: https://crrev.com/b8729366a6d05e96f6283b077e500b1d882abfe7 Cr-Commit-Position: refs/heads/master@{#293223}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Code review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -2 lines) Patch
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc View 1 4 chunks +33 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
ananta
6 years, 3 months ago (2014-09-03 01:02:05 UTC) #1
sky
LGTM https://codereview.chromium.org/528173002/diff/1/ui/views/widget/desktop_aura/desktop_window_tree_host_win.h File ui/views/widget/desktop_aura/desktop_window_tree_host_win.h (right): https://codereview.chromium.org/528173002/diff/1/ui/views/widget/desktop_aura/desktop_window_tree_host_win.h#newcode268 ui/views/widget/desktop_aura/desktop_window_tree_host_win.h:268: // via the compositor. Cases include restoring/resizing/maximizing the ...
6 years, 3 months ago (2014-09-03 14:53:51 UTC) #2
ananta
https://codereview.chromium.org/528173002/diff/1/ui/views/widget/desktop_aura/desktop_window_tree_host_win.h File ui/views/widget/desktop_aura/desktop_window_tree_host_win.h (right): https://codereview.chromium.org/528173002/diff/1/ui/views/widget/desktop_aura/desktop_window_tree_host_win.h#newcode268 ui/views/widget/desktop_aura/desktop_window_tree_host_win.h:268: // via the compositor. Cases include restoring/resizing/maximizing the On ...
6 years, 3 months ago (2014-09-03 17:44:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ananta@chromium.org/528173002/20001
6 years, 3 months ago (2014-09-03 18:44:36 UTC) #5
cpu_(ooo_6.6-7.5)
lgtm
6 years, 3 months ago (2014-09-03 22:02:38 UTC) #6
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-09-03 23:06:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ananta@chromium.org/528173002/20001
6 years, 3 months ago (2014-09-03 23:23:22 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as efb4ed49e60257ac52002ebd080c69a3ab35c3ce
6 years, 3 months ago (2014-09-03 23:46:29 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:28:37 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b8729366a6d05e96f6283b077e500b1d882abfe7
Cr-Commit-Position: refs/heads/master@{#293223}

Powered by Google App Engine
This is Rietveld 408576698