InstantExtended: update tests for Instant Extended (part 2).

InstantExtended: update tests for Instant Extended (part 2).

Update tests that were using the wrong test for checking the NTP URL. Once
Instant Extended is turned on, IsNTPURL will not return true for
"chrome://newtab", so the tests expecting that particular literal must be
updated. (Ultimately, this should be cleaned up so there is no distinction
between chrome://newtab and chrome-search://local-ntp.. but that will need to
happen later.)

(Note that this is split off from http://crrev.com/24733003.)

BUG=297915
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235029

[samarth, 2013-11-13 17:57:28]

PTAL.

Thanks,
Samarth

[sky, 2013-11-13 21:19:36]

https://codereview.chromium.org/58903004/diff/1/chrome/browser/policy/policy_...
File chrome/browser/policy/policy_browsertest.cc (right):

https://codereview.chromium.org/58903004/diff/1/chrome/browser/policy/policy_...
chrome/browser/policy/policy_browsertest.cc:1717:
EXPECT_EQ(GURL(chrome::kChromeUINewTabURL), contents->GetURL());
I'm pretty sure the failure for GURL comparisons isn't particularly useful,
where as if you compare strings you can see what the different was.

[samarth, 2013-11-13 21:41:41]

https://codereview.chromium.org/58903004/diff/1/chrome/browser/policy/policy_...
File chrome/browser/policy/policy_browsertest.cc (right):

https://codereview.chromium.org/58903004/diff/1/chrome/browser/policy/policy_...
chrome/browser/policy/policy_browsertest.cc:1717:
EXPECT_EQ(GURL(chrome::kChromeUINewTabURL), contents->GetURL());
On 2013/11/13 21:19:36, sky wrote:
> I'm pretty sure the failure for GURL comparisons isn't particularly useful,
> where as if you compare strings you can see what the different was.

I was curious, so I just ran a unit test with:
  GURL a("http://a.com/");
  GURL b("http://b.com/");
  EXPECT_EQ(a, b);
and the output actually turns out to be useful:
: Failure
Value of: b
  Actual: http://b.com/
Expected: a
Which is: http://a.com/

[sky, 2013-11-13 22:20:11]

My mistake, LGTM

[commit-bot: I haz the power, 2013-11-13 22:45:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/samarth@chromium.org/58903004/1

[commit-bot: I haz the power, 2013-11-14 03:20:39]

Change committed as 235029