chrome/browser/extensions/lazy_background_page_apitest.cc - Issue 58903004: InstantExtended: update tests for Instant Extended (part 2).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/lazy_background_page_apitest.cc

Issue 58903004: InstantExtended: update tests for Instant Extended (part 2). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_url_rewrite_browsertest.cc ('k') | chrome/browser/policy/policy_browsertest.cc » ('j') | chrome/browser/policy/policy_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/lazy_background_page_apitest.cc

diff --git a/chrome/browser/extensions/lazy_background_page_apitest.cc b/chrome/browser/extensions/lazy_background_page_apitest.cc

index f526a7443ab55de3f9aa11cda4188d912f4ebaaf..296f3aa02d3c68ac5e87540f1318f9b49d3afc0a 100644

--- a/chrome/browser/extensions/lazy_background_page_apitest.cc

+++ b/chrome/browser/extensions/lazy_background_page_apitest.cc

@@ -18,7 +18,6 @@

#include "chrome/browser/extensions/extension_test_message_listener.h"

#include "chrome/browser/extensions/lazy_background_page_test_util.h"

#include "chrome/browser/profiles/profile.h"

-#include "chrome/browser/search/search.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_window.h"

#include "chrome/browser/ui/omnibox/location_bar.h"

@@ -287,9 +286,8 @@ IN_PROC_BROWSER_TEST_F(LazyBackgroundPageApiTest, MAYBE_WaitForNTP) {

EXPECT_TRUE(catcher.GetNextResult()) << catcher.message();

// The extension should've opened a new tab to an extension page.

- EXPECT_TRUE(chrome::IsNTPURL(

- browser()->tab_strip_model()->GetActiveWebContents()->GetURL(),

- browser()->profile()));

+ EXPECT_EQ(GURL(chrome::kChromeUINewTabURL),

+ browser()->tab_strip_model()->GetActiveWebContents()->GetURL());

// Lazy Background Page still exists, because the extension created a new tab

// to an extension page.