Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Issue 588893005: Subzero: Make tests stricter after fixing "lock foo" bundling bug. (Closed)

Created:
6 years, 3 months ago by jvoung (off chromium)
Modified:
6 years, 3 months ago
Reviewers:
Jim Stichnoth
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Make tests stricter after fixing "lock foo" bundling bug. Should be fixed now. BUG=https://code.google.com/p/nativeclient/issues/detail?id=3929 R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=cff9dae72be7c5c762bbc26333cd1464812836ef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -22 lines) Patch
M tests_lit/llvm2ice_tests/nacl-atomic-cmpxchg-optimization.ll View 1 chunk +1 line, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/nacl-atomic-intrinsics.ll View 8 chunks +7 lines, -20 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jvoung (off chromium)
6 years, 3 months ago (2014-09-22 18:10:13 UTC) #2
Jim Stichnoth
lgtm
6 years, 3 months ago (2014-09-22 21:02:45 UTC) #3
jvoung (off chromium)
6 years, 3 months ago (2014-09-22 21:44:06 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as cff9dae (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698