chrome/browser/resources/print_preview/component.js - Issue 588713002: Compile print_preview, part 3: reduce down to 185 errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/print_preview/component.js

Issue 588713002: Compile print_preview, part 3: reduce down to 185 errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@I_print_preview_2

Patch Set: revert movement of enums: now handle in compiler pass Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/print_preview/common/search_box.js ('k') | chrome/browser/resources/print_preview/data/app_state.js » ('j') | chrome/browser/resources/print_preview/data/app_state.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/print_preview/component.js

diff --git a/chrome/browser/resources/print_preview/component.js b/chrome/browser/resources/print_preview/component.js

index 3437a31a1c6fb62622f60473bdd2c213cb333d97..73024b3e950fd3863e99b42b9d40214013c036d8 100644

--- a/chrome/browser/resources/print_preview/component.js

+++ b/chrome/browser/resources/print_preview/component.js

@@ -159,7 +159,7 @@ cr.define('print_preview', function() {

* something like getRequiredChildElement.

Dan Beam 2014/09/29 18:42:00 either remove this ^ or figure out how to address

Vitaly Pavlenko 2014/10/01 00:33:37 Removed the assert for now.

getChildElement: function(query) {

- return assert(this.element_.querySelector(query));

+ return assertInstanceof(this.element_.querySelector(query), HTMLElement);

/**

@@ -189,7 +189,7 @@ cr.define('print_preview', function() {

var templateEl = $(templateId);

assert(templateEl != null,

'Could not find element with ID: ' + templateId);

- var el = templateEl.cloneNode(true);

+ var el = assertInstanceof(templateEl.cloneNode(true), HTMLElement);

el.id = '';

if (!opt_keepHidden) {

setIsVisible(el, true);