Chromium Code Reviews| Index: chrome/browser/resources/print_preview/data/app_state.js |
| diff --git a/chrome/browser/resources/print_preview/data/app_state.js b/chrome/browser/resources/print_preview/data/app_state.js |
| index ffdda9a13c1ee6b79735bd8469470af02b1377e4..9f3449a3bc9189c26a822cdb04a140a970a73d0c 100644 |
| --- a/chrome/browser/resources/print_preview/data/app_state.js |
| +++ b/chrome/browser/resources/print_preview/data/app_state.js |
| @@ -12,7 +12,7 @@ cr.define('print_preview', function() { |
| function AppState() { |
| /** |
| * Internal representation of application state. |
| - * @type {Object.<string: Object>} |
| + * @type {Object.<string, print_preview.ValueType>} |
|
Dan Beam
2014/09/29 18:42:00
are you sure this is used? the templatized object
Vitaly Pavlenko
2014/10/01 00:33:37
Removed the template parameters, as here they are
|
| * @private |
| */ |
| this.state_ = {}; |
| @@ -80,7 +80,10 @@ cr.define('print_preview', function() { |
| return this.state_[AppState.Field.SELECTED_DESTINATION_ACCOUNT]; |
| }, |
| - /** @return {?string} Origin of the selected destination. */ |
| + /** |
| + * @return {?print_preview.Destination.Origin.<string>} Origin of the |
|
Dan Beam
2014/09/29 18:42:00
whhhhat?
Vitaly Pavlenko
2014/10/01 00:33:37
It means "the string that is a key in enum":
http
|
| + * selected destination. |
| + */ |
| get selectedDestinationOrigin() { |
| return this.state_[AppState.Field.SELECTED_DESTINATION_ORIGIN]; |
| }, |
| @@ -111,7 +114,7 @@ cr.define('print_preview', function() { |
| /** |
| * @param {!print_preview.AppState.Field} field App state field to get. |
| - * @return {Object} Value of the app state field. |
| + * @return {print_preview.ValueType} Value of the app state field. |
| */ |
| getField: function(field) { |
| if (field == AppState.Field.CUSTOM_MARGINS) { |
| @@ -163,7 +166,7 @@ cr.define('print_preview', function() { |
| /** |
| * Persists the given value for the given field. |
| * @param {!print_preview.AppState.Field} field Field to persist. |
| - * @param {Object} value Value of field to persist. |
| + * @param {print_preview.ValueType} value Value of field to persist. |
| */ |
| persistField: function(field, value) { |
| if (!this.isInitialized_) |