Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 588343002: Fix crash in tracing for chrome.identity.getAuthToken (Closed)

Created:
6 years, 3 months ago by Michael Courage
Modified:
6 years, 3 months ago
Reviewers:
fgorski
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix crash in tracing for chrome.identity.getAuthToken A trace statement in the IdentityGetAuthTokenFunction constructor was trying to use the app ID, which is not available until later. Moving the statement to RunAsync fixes the crash. BUG=411396 Committed: https://crrev.com/3c02f795c743e9cfbd4986d232836c8ab4f03997 Cr-Commit-Position: refs/heads/master@{#296073}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M chrome/browser/extensions/api/identity/identity_api.cc View 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Courage
6 years, 3 months ago (2014-09-22 21:19:57 UTC) #2
fgorski
lgtm
6 years, 3 months ago (2014-09-22 21:23:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/588343002/1
6 years, 3 months ago (2014-09-22 21:29:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as ab238cd26f76274976623b44c9cfb5e4ddb86c5f
6 years, 3 months ago (2014-09-22 22:35:13 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 22:35:44 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3c02f795c743e9cfbd4986d232836c8ab4f03997
Cr-Commit-Position: refs/heads/master@{#296073}

Powered by Google App Engine
This is Rietveld 408576698