Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Unified Diff: chrome/browser/extensions/api/identity/identity_api.cc

Issue 588343002: Fix crash in tracing for chrome.identity.getAuthToken (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/identity/identity_api.cc
diff --git a/chrome/browser/extensions/api/identity/identity_api.cc b/chrome/browser/extensions/api/identity/identity_api.cc
index 58c41aa8b8b6c6212135d7a7b1afacf4bfb06322..a06ed5b8c95a3597ce1f5dc8378822d95402b7da 100644
--- a/chrome/browser/extensions/api/identity/identity_api.cc
+++ b/chrome/browser/extensions/api/identity/identity_api.cc
@@ -288,11 +288,6 @@ IdentityGetAuthTokenFunction::IdentityGetAuthTokenFunction()
: OAuth2TokenService::Consumer("extensions_identity_api"),
should_prompt_for_scopes_(false),
should_prompt_for_signin_(false) {
- TRACE_EVENT_ASYNC_BEGIN1("identity",
- "IdentityGetAuthTokenFunction",
- this,
- "extension",
- extension()->id());
}
IdentityGetAuthTokenFunction::~IdentityGetAuthTokenFunction() {
@@ -300,6 +295,12 @@ IdentityGetAuthTokenFunction::~IdentityGetAuthTokenFunction() {
}
bool IdentityGetAuthTokenFunction::RunAsync() {
+ TRACE_EVENT_ASYNC_BEGIN1("identity",
+ "IdentityGetAuthTokenFunction",
+ this,
+ "extension",
+ extension()->id());
+
if (GetProfile()->IsOffTheRecord()) {
error_ = identity_constants::kOffTheRecord;
return false;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698