Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Unified Diff: ui/views/widget/widget_unittest.cc

Issue 588113002: Change Widget::GetAllOwnedWidgets to return child widgets as well (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@aid_resilient_to_uninstall_and_profile_changes
Patch Set: Merged GetAllChildWidgets and GetAllOwnedWidgets Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ui/views/controls/native/native_view_host.cc ('K') | « ui/views/widget/widget.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/widget/widget_unittest.cc
diff --git a/ui/views/widget/widget_unittest.cc b/ui/views/widget/widget_unittest.cc
index 374435f6b038fa0de5b389f73b05e601a26e2f45..b41241ed51e6df52f744e1d8269f4ee8576d3caa 100644
--- a/ui/views/widget/widget_unittest.cc
+++ b/ui/views/widget/widget_unittest.cc
@@ -2666,8 +2666,8 @@ TEST_F(WidgetTest, DisabledGestureEventTarget) {
widget->Close();
}
-// Test the result of Widget::GetAllChildWidgets().
-TEST_F(WidgetTest, GetAllChildWidgets) {
+// Test the result of Widget::GetAllChildAndOwnedWidgets().
+TEST_F(WidgetTest, GetAllChildAndOwnedWidgets) {
// Create the following widget hierarchy:
//
// toplevel
@@ -2692,7 +2692,7 @@ TEST_F(WidgetTest, GetAllChildWidgets) {
expected.insert(w22);
std::set<Widget*> widgets;
- Widget::GetAllChildWidgets(toplevel->GetNativeView(), &widgets);
+ Widget::GetAllChildAndOwnedWidgets(toplevel->GetNativeView(), &widgets);
EXPECT_EQ(expected.size(), widgets.size());
EXPECT_TRUE(std::equal(expected.begin(), expected.end(), widgets.begin()));
« ui/views/controls/native/native_view_host.cc ('K') | « ui/views/widget/widget.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698