Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 588003002: Remove implicit conversions from scoped_refptr to T* in FileWatcher. (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in FileWatcher. Since set_message_loop() takes ownership of the MessageLoop parameter anyway, just pass it a const scoped_refptr<T>&, rather than converting from scoped_refptr to T* back to scoped_refptr. BUG=110610 TBR=rvargas@chromioum.org Committed: https://crrev.com/4b82c97e55efb84e4e0ebad6fa9625d9b5e2234e Cr-Commit-Position: refs/heads/master@{#295875}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M base/files/file_path_watcher.h View 1 chunk +1 line, -1 line 0 comments Download
M base/files/file_path_watcher_linux.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
dcheng
TBRing this as this + https://codereview.chromium.org/584373002 should let me disable scoped_refptr conversions on Mac as ...
6 years, 3 months ago (2014-09-20 11:05:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/588003002/1
6 years, 3 months ago (2014-09-20 11:05:44 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as e9432e46ac89cbf2c59e14973b3262cef738ef12
6 years, 3 months ago (2014-09-20 14:53:18 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-20 14:54:02 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4b82c97e55efb84e4e0ebad6fa9625d9b5e2234e
Cr-Commit-Position: refs/heads/master@{#295875}

Powered by Google App Engine
This is Rietveld 408576698