Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Issue 584373002: Remove implicit conversions from scoped_refptr to T* in PasswordStoreMac test. (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
Reviewers:
stuartmorgan
CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in PasswordStoreMac test. - Add a .get() to a boolean test until boolean tests on scoped_refptr can be re-enabled. - Change the test fixture store() accessor to just return a raw pointer, since no one depends on it returning a scoped_refptr anyway. BUG=110610 TBR=stuartmorgan@chromium.org Committed: https://crrev.com/e11270b34fa8d3a2258f2b8687f575552ca4f2cb Cr-Commit-Position: refs/heads/master@{#295873}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/password_manager/password_store_mac_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
6 years, 3 months ago (2014-09-20 11:01:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/584373002/1
6 years, 3 months ago (2014-09-20 11:02:50 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 9cdc9e3d5fd8f13f64c21b6addd8f13729f343ac
6 years, 3 months ago (2014-09-20 13:23:12 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e11270b34fa8d3a2258f2b8687f575552ca4f2cb Cr-Commit-Position: refs/heads/master@{#295873}
6 years, 3 months ago (2014-09-20 13:23:48 UTC) #6
stuartmorgan
6 years, 3 months ago (2014-09-22 22:55:04 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698