Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: extensions/browser/app_window/app_delegate.h

Issue 587913002: app_shell: Remove some NOTIMPLEMENTED from ShellNativeAppWindow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | extensions/shell/browser/shell_app_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/app_window/app_delegate.h
diff --git a/extensions/browser/app_window/app_delegate.h b/extensions/browser/app_window/app_delegate.h
index 2d5fa1deb33dfdfea9324fd5e0dcba0842d25a22..7961f2afa4d0700b43e4c56809c049b129fa3372 100644
--- a/extensions/browser/app_window/app_delegate.h
+++ b/extensions/browser/app_window/app_delegate.h
@@ -68,6 +68,9 @@ class AppDelegate {
content::MediaStreamType type,
const Extension* extension) = 0;
virtual int PreferredIconSize() = 0;
+
+ // TODO(jamescook): Eliminate this method. All implementations load the same
+ // icon, and the icon is available in the extensions module resources.
virtual gfx::ImageSkia GetAppDefaultIcon() = 0;
// Web contents modal dialog support.
« no previous file with comments | « no previous file | extensions/shell/browser/shell_app_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698