Silence common noisiness in download_from_google_storage

Silence common noisiness in download_from_google_storage

Seems overly verbose when run in "gclient runhooks".

R=iannucci@chromium.org, brettw@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=237120

[M-A Ruel, 2013-11-05 01:58:48]

+Ryan since he's the primary author.

[Ryan Tseng, 2013-11-05 05:59:06]

What about just putting this behind a --verbose flag?

[scottmg, 2013-11-05 15:19:36]

On 2013/11/05 05:59:06, Ryan T. wrote:
> What about just putting this behind a --verbose flag?

Done.

[Ryan Tseng, 2013-11-05 17:04:40]

lgtm % passing tests/download_from_google_storage_unittests.py (I think some
function calls need to be modified)

[scottmg, 2013-11-05 17:28:03]

On 2013/11/05 17:04:40, Ryan T. wrote:
> lgtm % passing tests/download_from_google_storage_unittests.py (I think some
> function calls need to be modified)

Thanks. I'll have to leave this for a while then as the tests don't run on
Windows and I don't have a non-Windows around right now.

[Ryan Tseng, 2013-11-25 17:37:51]

Scott: Hows this going? If finding a box to test on is an issue I can take it
over from here.

[scottmg, 2013-11-25 17:50:01]

On 2013/11/25 17:37:51, Ryan T. wrote:
> Scott: Hows this going? If finding a box to test on is an issue I can take it
> over from here.

Hey, sorry. Setting up a Linux box now, I'll take care of it today.

[scottmg, 2013-11-25 18:11:26]

On 2013/11/25 17:50:01, scottmg wrote:
> On 2013/11/25 17:37:51, Ryan T. wrote:
> > Scott: Hows this going? If finding a box to test on is an issue I can take
it
> > over from here.
> 
> Hey, sorry. Setting up a Linux box now, I'll take care of it today.

Actually, I guess the CQ runs the presubmit right? I can bash through that
way...

[Ryan Tseng, 2013-11-25 18:13:29]

These tests don't run through presubmit, I'll need to put in a CL to enable that

[commit-bot: I haz the power, 2013-11-25 19:09:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/58783002/120001

[commit-bot: I haz the power, 2013-11-25 19:11:25]

Presubmit check for 58783002-120001 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    depot_tools/download_from_google_storage.py
    depot_tools/tests/download_from_google_storage_unittests.py

Presubmit checks took 131.4s to calculate.

[M-A Ruel, 2013-11-25 19:13:44]

lgtm with fix.

https://codereview.chromium.org/58783002/diff/120001/download_from_google_sto...
File download_from_google_storage.py (right):

https://codereview.chromium.org/58783002/diff/120001/download_from_google_sto...
download_from_google_storage.py:313: parser.add_option('-v', '--verbose',
default=False, action='store_true',
default=False is not needed, please remove.

[scottmg, 2013-11-25 19:23:40]

https://codereview.chromium.org/58783002/diff/120001/download_from_google_sto...
File download_from_google_storage.py (right):

https://codereview.chromium.org/58783002/diff/120001/download_from_google_sto...
download_from_google_storage.py:313: parser.add_option('-v', '--verbose',
default=False, action='store_true',
On 2013/11/25 19:13:44, M-A Ruel wrote:
> default=False is not needed, please remove.

Done.

[commit-bot: I haz the power, 2013-11-25 19:25:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/58783002/170001

[commit-bot: I haz the power, 2013-11-25 19:29:00]

Change committed as 237120