Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: tests/download_from_google_storage_unittests.py

Issue 58783002: Silence common noisiness in download_from_google_storage (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « download_from_google_storage.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/download_from_google_storage_unittests.py
===================================================================
--- tests/download_from_google_storage_unittests.py (revision 237112)
+++ tests/download_from_google_storage_unittests.py (working copy)
@@ -173,7 +173,7 @@
stdout_queue = Queue.Queue()
download_from_google_storage._downloader_worker_thread(
0, self.queue, False, self.base_url, self.gsutil,
- stdout_queue, self.ret_codes)
+ stdout_queue, self.ret_codes, True)
expected_calls = [
('check_call',
('ls', input_filename)),
@@ -200,7 +200,7 @@
stdout_queue = Queue.Queue()
download_from_google_storage._downloader_worker_thread(
0, self.queue, False, self.base_url, self.gsutil,
- stdout_queue, self.ret_codes)
+ stdout_queue, self.ret_codes, True)
expected_output = [
'0> File %s exists and SHA1 matches. Skipping.' % output_filename
]
@@ -217,7 +217,7 @@
self.gsutil.add_expected(1, '', '') # Return error when 'ls' is called.
download_from_google_storage._downloader_worker_thread(
0, self.queue, False, self.base_url, self.gsutil,
- stdout_queue, self.ret_codes)
+ stdout_queue, self.ret_codes, True)
expected_output = [
'0> File %s for %s does not exist, skipping.' % (
input_filename, output_filename),
@@ -250,7 +250,8 @@
force=True,
output=output_filename,
ignore_errors=False,
- sha1_file=False)
+ sha1_file=False,
+ verbose=True)
expected_calls = [
('check_call',
('ls', input_filename)),
@@ -280,7 +281,8 @@
force=False,
output=None,
ignore_errors=False,
- sha1_file=False)
+ sha1_file=False,
+ verbose=True)
expected_calls = [
('check_call',
('ls', input_filename)),
« no previous file with comments | « download_from_google_storage.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698