Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Unified Diff: chrome/browser/resources/contextual_search/promo.html

Issue 587803003: [Search] Add a header image to the promo flow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Using finch parameter for hiding the header Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/contextual_search/promo.html
diff --git a/chrome/browser/resources/contextual_search/promo.html b/chrome/browser/resources/contextual_search/promo.html
index 4d5e1120d58481e7e163759ea6f2b4e54f7ed51f..f66e6799dd574359e233ea3edb016a033c0ff739 100644
--- a/chrome/browser/resources/contextual_search/promo.html
+++ b/chrome/browser/resources/contextual_search/promo.html
@@ -4,15 +4,15 @@
Use of this source code is governed by a BSD-style license that can be
found in the LICENSE file. -->
<head>
- <script src="../../../../ui/webui/resources/js/util.js"></script>
- <script src="../../../../ui/webui/resources/js/load_time_data.js"></script>
- <script src="promo.js"></script>
+ <script src="chrome://contextual-search-promo/config.js"></script>
+ <script src="chrome://contextual-search-promo/promo.js"></script>
<link rel="stylesheet" href="promo.css">
pedro (no code reviews) 2014/09/22 18:25:20 For maximum rendering performance CSS should come
Mathieu 2014/09/22 21:35:06 Done.
<meta charset="utf-8">
pedro (no code reviews) 2014/09/22 18:25:20 Nit: meta tags come before script and stylesheets.
Mathieu 2014/09/22 21:35:06 Done.
<meta name="viewport" content="width=device-width, user-scalable=no">
</head>
<body>
<div id="container">
+ <img id="header-image" src="header.svg">
<p i18n-content="heading" id="heading"></p>
<p i18n-content="description" id="description"></p>
<div id="button-container">

Powered by Google App Engine
This is Rietveld 408576698