chrome/browser/resources/contextual_search/promo.html - Issue 587803003: [Search] Add a header image to the promo flow.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/contextual_search/promo.html

Issue 587803003: [Search] Add a header image to the promo flow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Using finch parameter for hiding the header Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/contextual_search/promo.css ('k') | chrome/browser/resources/contextual_search/promo.js » ('j') | chrome/browser/resources/contextual_search/promo.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <!-- Copyright 2014 The Chromium Authors. All rights reserved.	3 <!-- Copyright 2014 The Chromium Authors. All rights reserved.

4 Use of this source code is governed by a BSD-style license that can be	4 Use of this source code is governed by a BSD-style license that can be

5 found in the LICENSE file. -->	5 found in the LICENSE file. -->

6 <head>	6 <head>

7 <script src="../../../../ui/webui/resources/js/util.js"></script>	7 <script src="chrome://contextual-search-promo/config.js"></script>

8 <script src="../../../../ui/webui/resources/js/load_time_data.js"></script>	8 <script src="chrome://contextual-search-promo/promo.js"></script>

9 <script src="promo.js"></script>

10 <link rel="stylesheet" href="promo.css">	9 <link rel="stylesheet" href="promo.css">
	pedro (no code reviews) 2014/09/22 18:25:20 For maximum rendering performance CSS should come For maximum rendering performance CSS should come first, then scripts. Mathieu 2014/09/22 21:35:06 Done. Show quoted text On 2014/09/22 18:25:20, pedrosimonetti wrote: > For maximum rendering performance CSS should come first, then scripts. Done.
11 <meta charset="utf-8">	10 <meta charset="utf-8">
	pedro (no code reviews) 2014/09/22 18:25:20 Nit: meta tags come before script and stylesheets. Nit: meta tags come before script and stylesheets. Also include a <title> tag? Mathieu 2014/09/22 21:35:06 Done. Show quoted text On 2014/09/22 18:25:20, pedrosimonetti wrote: > Nit: meta tags come before script and stylesheets. Also include a <title> tag? Done.
12 <meta name="viewport" content="width=device-width, user-scalable=no">	11 <meta name="viewport" content="width=device-width, user-scalable=no">

13 </head>	12 </head>

14 <body>	13 <body>

15 <div id="container">	14 <div id="container">

	15 <img id="header-image" src="header.svg">

16 <p i18n-content="heading" id="heading"></p>	16 <p i18n-content="heading" id="heading"></p>

17 <p i18n-content="description" id="description"></p>	17 <p i18n-content="description" id="description"></p>

18 <div id="button-container">	18 <div id="button-container">

19 <span class="label"><a href="#optout" i18n-content="optOut"></a></span>	19 <span class="label"><a href="#optout" i18n-content="optOut"></a></span>

20 <span id="optin-label" class="label"><a class="colored" href="#optin" i18n -content="optIn"></a></span>	20 <span id="optin-label" class="label"><a class="colored" href="#optin" i18n -content="optIn"></a></span>

21 </div>	21 </div>

22 </div>	22 </div>

23 </body>	23 </body>

24 </html>	24 </html>

OLD	NEW