Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 58773002: Revert 232877 "Switch the WebstoreDataFetcherDelegate::OnWebstor..." (Closed)

Created:
7 years, 1 month ago by Mallinath (Gone from Chromium)
Modified:
7 years, 1 month ago
Reviewers:
earthdok
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 232877 "Switch the WebstoreDataFetcherDelegate::OnWebstor..." http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder/builds/58330 > Switch the WebstoreDataFetcherDelegate::OnWebstoreResponseParseSuccess interface to scoped_ptr. > > Fixes memory leaks. > > BUG=313695 > R=benwells@chromium.org > TBR=satorux@chromium.org > > Review URL: https://codereview.chromium.org/51113014 TBR=earthdok@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232880

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -13 lines) Patch
M trunk/src/chrome/browser/chromeos/app_mode/kiosk_app_data.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/chromeos/app_mode/kiosk_app_data.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/extensions/webstore_data_fetcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/extensions/webstore_data_fetcher_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/extensions/webstore_standalone_installer.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/extensions/webstore_standalone_installer.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mallinath (Gone from Chromium)
7 years, 1 month ago (2013-11-05 01:48:59 UTC) #1
Mallinath (Gone from Chromium)
7 years, 1 month ago (2013-11-05 01:52:17 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r232880 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698