Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(919)

Issue 51113014: Switch the WebstoreDataFetcherDelegate::OnWebstoreResponseParseSuccess interface to scoped_ptr. (Closed)

Created:
7 years, 1 month ago by earthdok
Modified:
7 years, 1 month ago
Reviewers:
benwells, satorux1
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Switch the WebstoreDataFetcherDelegate::OnWebstoreResponseParseSuccess interface to scoped_ptr. Fixes memory leaks. BUG=313695 R=benwells@chromium.org TBR=satorux@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232877

Patch Set 1 #

Patch Set 2 : reupload #

Total comments: 1

Patch Set 3 : fix chromeos code #

Patch Set 4 : really fix chromeos code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -14 lines) Patch
M chrome/browser/chromeos/app_mode/kiosk_app_data.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_app_data.cc View 1 2 3 1 chunk +6 lines, -7 lines 0 comments Download
M chrome/browser/extensions/webstore_data_fetcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/webstore_data_fetcher_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/webstore_standalone_installer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/webstore_standalone_installer.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
earthdok
PTAL benwells@ - c/b/extensions satorux@ - c/b/chromeos
7 years, 1 month ago (2013-10-31 14:54:37 UTC) #1
benwells
On 2013/10/31 14:54:37, earthdok wrote: > PTAL > > benwells@ - c/b/extensions > satorux@ - ...
7 years, 1 month ago (2013-11-01 00:01:33 UTC) #2
earthdok
On 2013/11/01 00:01:33, benwells wrote: > On 2013/10/31 14:54:37, earthdok wrote: > > PTAL > ...
7 years, 1 month ago (2013-11-01 01:07:47 UTC) #3
benwells
c/b/e lgtm. Were there actual leaks here or is this being proactive for future leaks? ...
7 years, 1 month ago (2013-11-01 06:01:01 UTC) #4
satorux1
c/b/chromeos lgtm
7 years, 1 month ago (2013-11-01 06:02:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/51113014/80001
7 years, 1 month ago (2013-11-01 06:04:11 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 1 month ago (2013-11-01 06:41:34 UTC) #7
earthdok
On 2013/11/01 06:01:01, benwells wrote: > c/b/e lgtm. Were there actual leaks here or is ...
7 years, 1 month ago (2013-11-01 07:49:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/51113014/360001
7 years, 1 month ago (2013-11-04 17:42:49 UTC) #9
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=97365
7 years, 1 month ago (2013-11-04 22:44:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/51113014/360001
7 years, 1 month ago (2013-11-04 23:32:34 UTC) #11
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 01:35:10 UTC) #12
Message was sent while issue was closed.
Change committed as 232877

Powered by Google App Engine
This is Rietveld 408576698