Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 587373002: Do not fire an initial periodic timeupdate event while currentTime is 0 (Closed)

Created:
6 years, 3 months ago by philipj_slow
Modified:
6 years, 3 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, nessy, vcarbune.chromium
Project:
blink
Visibility:
Public.

Description

Do not fire an initial periodic timeupdate event while currentTime is 0 m_lastTimeUpdateEventMovieTime has been initialized to infinity for as long as the code has existed: http://trac.webkit.org/changeset/41907 This may be the cause of a spurious timeupdate event on Mac 10.9 in a recently added test: https://codereview.chromium.org/578243003 TEST=media/gc-while-playing.html BUG=400659 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182442

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/html/HTMLMediaElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
philipj_slow
PTAL. Instead of https://codereview.chromium.org/574883002
6 years, 3 months ago (2014-09-22 13:36:29 UTC) #2
fs
Seems reasonable to me, so LGTM. Scherkus probably has a fresh recollection of this area ...
6 years, 3 months ago (2014-09-22 13:54:03 UTC) #3
philipj_slow
Yep, awaiting scherkus' feedback before landing.
6 years, 3 months ago (2014-09-22 14:25:31 UTC) #4
scherkus (not reviewing)
lgtm
6 years, 3 months ago (2014-09-22 17:51:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/587373002/1
6 years, 3 months ago (2014-09-22 17:53:47 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 18:45:46 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 182442

Powered by Google App Engine
This is Rietveld 408576698