Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 587173002: Fix crash caused by NULL response_headers passed to StreamHandleImpl (Closed)

Created:
6 years, 3 months ago by raymes
Modified:
6 years, 3 months ago
Reviewers:
Zachary Kuznia
CC:
chromium-reviews, darin-cc_chromium.org, jam, zork+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix crash caused by NULL response_headers passed to StreamHandleImpl This fixes a bug introduced in https://codereview.chromium.org/588643002 which caused a crash if NULL response_headers were passed to StreamhandleImpl. Committed: https://crrev.com/e57554330986316adc725edc9ca8dfece4709d4c Cr-Commit-Position: refs/heads/master@{#296104}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M content/browser/streams/stream_handle_impl.cc View 1 1 chunk +9 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
raymes
6 years, 3 months ago (2014-09-22 05:50:11 UTC) #2
Zachary Kuznia
lgtm
6 years, 3 months ago (2014-09-22 22:39:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/587173002/20001
6 years, 3 months ago (2014-09-22 23:31:02 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 30183a7e6aa098ca5b6701d9cd2af964ffa97a9d
6 years, 3 months ago (2014-09-23 00:22:10 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 00:22:49 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e57554330986316adc725edc9ca8dfece4709d4c
Cr-Commit-Position: refs/heads/master@{#296104}

Powered by Google App Engine
This is Rietveld 408576698