Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 588643002: Make a copy of HttpResponseHeaders in StreamHandleImpl. (Closed)

Created:
6 years, 3 months ago by davidben
Modified:
6 years, 3 months ago
Reviewers:
Zachary Kuznia
CC:
chromium-reviews, darin-cc_chromium.org, jam, zork+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make a copy of HttpResponseHeaders in StreamHandleImpl. BufferedResourceHandler passes the response to both the old and the new handler, so there is a race where the streams logic could access headers on the UI thread while the old handler (AsyncResourceHandler) is busy modifying them (via ChromeResourceDispatcherHostDelegate). BUG=none Committed: https://crrev.com/ed01b8549fd0a91de7d64015e120a09a30bb8987 Cr-Commit-Position: refs/heads/master@{#295753}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M content/browser/streams/stream_handle_impl.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
davidben
Noticed this in trying to sorting out the threading in the PlzNavigate CL.
6 years, 3 months ago (2014-09-19 17:15:44 UTC) #2
Zachary Kuznia
lgtm
6 years, 3 months ago (2014-09-19 18:12:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/588643002/1
6 years, 3 months ago (2014-09-19 18:19:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as df7bf622191d98a7b02a67543db9fa5d1087c20e
6 years, 3 months ago (2014-09-19 18:55:01 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 18:55:40 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed01b8549fd0a91de7d64015e120a09a30bb8987
Cr-Commit-Position: refs/heads/master@{#295753}

Powered by Google App Engine
This is Rietveld 408576698