Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(969)

Issue 586873003: extensions: Move sockets manifest handler registration (Closed)

Created:
6 years, 3 months ago by James Cook
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

extensions: Move sockets manifest handler registration It was being done as a one-off in app_shell and replicated in Chrome. Moved it to RegisterCommonManifestHandlers() where it belongs. BUG=none TEST=extensions_unittests, unit_tests Committed: https://crrev.com/4860e1a3ff5fc44544d3ff509424b3688cd0f7f9 Cr-Commit-Position: refs/heads/master@{#295842}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -9 lines) Patch
M chrome/common/extensions/chrome_manifest_handlers.cc View 2 chunks +0 lines, -2 lines 1 comment Download
M extensions/common/common_manifest_handlers.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M extensions/shell/common/shell_extensions_client.cc View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
James Cook
rockot, PTAL Feel free to CQ if it's nit-free. https://codereview.chromium.org/586873003/diff/1/chrome/common/extensions/chrome_manifest_handlers.cc File chrome/common/extensions/chrome_manifest_handlers.cc (right): https://codereview.chromium.org/586873003/diff/1/chrome/common/extensions/chrome_manifest_handlers.cc#newcode35 chrome/common/extensions/chrome_manifest_handlers.cc:35: ...
6 years, 3 months ago (2014-09-19 23:18:08 UTC) #2
Ken Rockot(use gerrit already)
weird that we were doing that. lgtm!
6 years, 3 months ago (2014-09-19 23:23:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/586873003/1
6 years, 3 months ago (2014-09-19 23:24:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 242644fb11a3ca7cc878c034a0687f8b007a1ae3
6 years, 3 months ago (2014-09-20 01:49:10 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-20 01:49:53 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4860e1a3ff5fc44544d3ff509424b3688cd0f7f9
Cr-Commit-Position: refs/heads/master@{#295842}

Powered by Google App Engine
This is Rietveld 408576698