Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: extensions/shell/common/shell_extensions_client.cc

Issue 586873003: extensions: Move sockets manifest handler registration (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/shell/common/shell_extensions_client.cc
diff --git a/extensions/shell/common/shell_extensions_client.cc b/extensions/shell/common/shell_extensions_client.cc
index 493accaf540b6e391d318ad3827641cd38b79f44..039841320dd8215f6899af07bdbd9d75effda48b 100644
--- a/extensions/shell/common/shell_extensions_client.cc
+++ b/extensions/shell/common/shell_extensions_client.cc
@@ -7,7 +7,6 @@
#include "base/lazy_instance.h"
#include "base/logging.h"
#include "extensions/common/api/generated_schemas.h"
-#include "extensions/common/api/sockets/sockets_manifest_handler.h"
#include "extensions/common/common_manifest_handlers.h"
#include "extensions/common/extension_urls.h"
#include "extensions/common/features/api_feature.h"
@@ -85,12 +84,6 @@ ShellExtensionsClient::~ShellExtensionsClient() {
void ShellExtensionsClient::Initialize() {
RegisterCommonManifestHandlers();
-
- // TODO(rockot): API manifest handlers which move out to src/extensions
- // should either end up in RegisterCommonManifestHandlers or some new
- // initialization step specifically for API manifest handlers.
- (new SocketsManifestHandler)->Register();
-
ManifestHandler::FinalizeRegistration();
// TODO(jamescook): Do we need to whitelist any extensions?

Powered by Google App Engine
This is Rietveld 408576698