Remove AppDelegate::GetAppDefaultIcon

Remove AppDelegate::GetAppDefaultIcon

The default app icon resource exists in the //extensions module resources
file and all implementations return the same icon. There's no need to delegate
this out.

BUG=none
TEST=app_shell, athena_main and chrome all run in debug without assertions
about missing resources

Committed: https://crrev.com/07cad3358348f9fc9af2b87d006f611d87b02316
Cr-Commit-Position: refs/heads/master@{#295916}

[James Cook, 2014-09-19 22:41:44]

jamescook@chromium.org changed reviewers:
+ mukai@chromium.org, rockot@chromium.org

[James Cook, 2014-09-19 22:41:45]

mukai, PTAL at athena/ and *.gyp

rockot, PTAL at extensions/

[Jun Mukai, 2014-09-19 22:51:55]

lgtm

[Ken Rockot(use gerrit already), 2014-09-19 23:25:35]

lgtm

[James Cook, 2014-09-20 03:08:38]

jamescook@chromium.org changed reviewers:
+ tapted@chromium.org

[James Cook, 2014-09-20 03:08:39]

tapted, can I get OWNERS for chrome/browser/ui/apps?

If it looks good feel free to CQ it

[tapted, 2014-09-22 00:02:05]

The CQ bit was checked by tapted@chromium.org

[tapted, 2014-09-22 00:02:05]

lgtm

looks good! A couple of musings, but nothing to do with this CL. CQ ahoy!

https://codereview.chromium.org/586853004/diff/20001/extensions/browser/app_w...
File extensions/browser/app_window/app_window.cc (right):

https://codereview.chromium.org/586853004/diff/20001/extensions/browser/app_w...
extensions/browser/app_window/app_window.cc:42: #include
"extensions/grit/extensions_browser_resources.h"
I wonder if we should remove the `browser` bit..

https://codereview.chromium.org/586853004/diff/20001/extensions/extensions.gyp
File extensions/extensions.gyp (right):

https://codereview.chromium.org/586853004/diff/20001/extensions/extensions.gy...
extensions/extensions.gyp:1003:
'<(SHARED_INTERMEDIATE_DIR)/extensions/extensions_resources.pak',
hm - this line repeats

[commit-bot: I haz the power, 2014-09-22 00:03:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/586853004/20001

[commit-bot: I haz the power, 2014-09-22 03:48:48]

Committed patchset #2 (id:20001) as 61e9ef0509a8e94687981071567eae386c2b1ed9

[commit-bot: I haz the power, 2014-09-22 03:49:27]

Patchset 2 (id:??) landed as
https://crrev.com/07cad3358348f9fc9af2b87d006f611d87b02316
Cr-Commit-Position: refs/heads/master@{#295916}

[James Cook, 2014-09-22 19:12:08]

https://codereview.chromium.org/586853004/diff/20001/extensions/extensions.gyp
File extensions/extensions.gyp (right):

https://codereview.chromium.org/586853004/diff/20001/extensions/extensions.gy...
extensions/extensions.gyp:1003:
'<(SHARED_INTERMEDIATE_DIR)/extensions/extensions_resources.pak',
On 2014/09/22 00:02:05, tapted wrote:
> hm - this line repeats

heh. I'll fix that in another CL.