athena/extensions/athena_app_delegate_base.cc - Issue 586853004: Remove AppDelegate::GetAppDefaultIcon

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: athena/extensions/athena_app_delegate_base.cc

Issue 586853004: Remove AppDelegate::GetAppDefaultIcon (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@not-impl

Patch Set: (app-icon) rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: athena/extensions/athena_app_delegate_base.cc

diff --git a/athena/extensions/athena_app_delegate_base.cc b/athena/extensions/athena_app_delegate_base.cc

index b3e2458c1aa5e0578fe10b27124eba091b6459a4..6cd4b93de3d75124b7dfb2deac3219d2725ada41 100644

--- a/athena/extensions/athena_app_delegate_base.cc

+++ b/athena/extensions/athena_app_delegate_base.cc

@@ -88,11 +88,6 @@ int AthenaAppDelegateBase::PreferredIconSize() {

return extension_misc::EXTENSION_ICON_SMALL;

}

-gfx::ImageSkia AthenaAppDelegateBase::GetAppDefaultIcon() {

- return *ResourceBundle::GetSharedInstance().GetImageSkiaNamed(

- IDR_APP_DEFAULT_ICON);

bool AthenaAppDelegateBase::IsWebContentsVisible(

content::WebContents* web_contents) {

return web_contents->GetNativeView()->IsVisible();