Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 586803002: Fix compile optimization in analyze.py in Android trybots. (Closed)

Created:
6 years, 3 months ago by jabdelmalek
Modified:
6 years, 3 months ago
CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build@master
Project:
tools
Visibility:
Public.

Description

Fix compile optimization in analyze.py in Android trybots. It looks like when the initial set of compile targets is an empty list, which is what happens for android_dbg_tests_recipe, then the intersection of it and the supplied list from analyze.py is empty. So we end up building everything. Fix this by detecting when there's no list initially, and just building whatever analyze.py says. BUG=405584, 109173 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292044

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M scripts/slave/recipes/android/tester.py View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/tester.expected/android_dbg_tests_recipe.json View 1 chunk +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/tester.expected/android_dbg_tests_recipe__content_browsertests_failure.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/android/tester.expected/android_rel_tests_recipe.json View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
jam
6 years, 3 months ago (2014-09-19 17:32:57 UTC) #2
sky
LGTM
6 years, 3 months ago (2014-09-19 17:37:41 UTC) #3
Paweł Hajdan Jr.
LGTM
6 years, 3 months ago (2014-09-19 17:50:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/586803002/1
6 years, 3 months ago (2014-09-19 17:52:55 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 17:54:01 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 292044

Powered by Google App Engine
This is Rietveld 408576698