Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: scripts/slave/recipes/android/tester.py

Issue 586803002: Fix compile optimization in analyze.py in Android trybots. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/android/tester.expected/android_dbg_tests_recipe.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 DEPS = [ 5 DEPS = [
6 'adb', 6 'adb',
7 'bot_update', 7 'bot_update',
8 'chromium', 8 'chromium',
9 'chromium_android', 9 'chromium_android',
10 'filter', 10 'filter',
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
139 139
140 compile_targets = api.chromium.c.compile_py.default_targets 140 compile_targets = api.chromium.c.compile_py.default_targets
141 api.filter.does_patch_require_compile( 141 api.filter.does_patch_require_compile(
142 exes=test_names, 142 exes=test_names,
143 compile_targets=compile_targets, 143 compile_targets=compile_targets,
144 additional_name='chromium', 144 additional_name='chromium',
145 config_file_name='trybot_analyze_config.json') 145 config_file_name='trybot_analyze_config.json')
146 if not api.filter.result: 146 if not api.filter.result:
147 return 147 return
148 compile_targets = list(set(compile_targets) & 148 compile_targets = list(set(compile_targets) &
149 set(api.filter.compile_targets)) 149 set(api.filter.compile_targets)) if \
150 compile_targets else api.filter.compile_targets
150 instrumentation_tests = [i for i in instrumentation_tests if \ 151 instrumentation_tests = [i for i in instrumentation_tests if \
151 i['gyp_target'] in api.filter.matching_exes] 152 i['gyp_target'] in api.filter.matching_exes]
152 unittests = [i for i in unittests if i[0] in api.filter.matching_exes] 153 unittests = [i for i in unittests if i[0] in api.filter.matching_exes]
153 154
154 api.chromium_android.run_tree_truth() 155 api.chromium_android.run_tree_truth()
155 api.chromium_android.compile(targets=compile_targets) 156 api.chromium_android.compile(targets=compile_targets)
156 157
157 api.adb.root_devices() 158 api.adb.root_devices()
158 159
159 api.chromium_android.spawn_logcat_monitor() 160 api.chromium_android.spawn_logcat_monitor()
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
215 yield ( 216 yield (
216 api.test('no_compile_because_of_analyze') + 217 api.test('no_compile_because_of_analyze') +
217 api.properties.generic( 218 api.properties.generic(
218 mastername='tryserver.chromium.linux', 219 mastername='tryserver.chromium.linux',
219 buildername='android_dbg_tests_recipe', 220 buildername='android_dbg_tests_recipe',
220 slavename='slavename') + 221 slavename='slavename') +
221 api.override_step_data( 222 api.override_step_data(
222 'analyze', 223 'analyze',
223 api.json.output({'status': 'No compile necessary'})) 224 api.json.output({'status': 'No compile necessary'}))
224 ) 225 )
OLDNEW
« no previous file with comments | « no previous file | scripts/slave/recipes/android/tester.expected/android_dbg_tests_recipe.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698