SkTextBlob shader space workaround.

SkTextBlob shader space workaround.

Blink would like drawTextBlob(x,y) to behave the same as drawText(x,y)
WRT shader space. Due to the current generic device base impl, that is
not the case.

This is a transitional workaround, pending proper drawTextBlob impls
in SkDevice classes.

R=robertphillips@google.com,reed@google.com

Committed: https://skia.googlesource.com/skia/+/8483326704eff3b6a5fcce3f36d857a9779a4dd2

[reed1, 2014-09-19 16:47:19]

lgtm

https://codereview.chromium.org/586743002/diff/1/src/core/SkDevice.cpp
File src/core/SkDevice.cpp (right):

https://codereview.chromium.org/586743002/diff/1/src/core/SkDevice.cpp#newcod...
src/core/SkDevice.cpp:111: if (paint.getShader()) {
Tricky, but seems fine for now.

Perhaps a TODO to consider passing x,y to the other methods, so they could
handle the additional translate w/o needing to allocate a new shader.

[robertphillips, 2014-09-19 17:20:27]

https://codereview.chromium.org/586743002/diff/1/gm/textblobshader.cpp
File gm/textblobshader.cpp (right):

https://codereview.chromium.org/586743002/diff/1/gm/textblobshader.cpp#newcode17
gm/textblobshader.cpp:17: 
// This GM exercises ... ?

https://codereview.chromium.org/586743002/diff/1/gm/textblobshader.cpp#newcode20
gm/textblobshader.cpp:20: TextBlobShaderGM(const char* txt) {
Would it make sense to do any or all of this in onOnceBeforeDraw ?

[f(malita), 2014-09-19 17:55:53]

https://codereview.chromium.org/586743002/diff/1/gm/textblobshader.cpp
File gm/textblobshader.cpp (right):

https://codereview.chromium.org/586743002/diff/1/gm/textblobshader.cpp#newcode17
gm/textblobshader.cpp:17: 
On 2014/09/19 17:20:26, robertphillips wrote:
> // This GM exercises ... ?

Done.

https://codereview.chromium.org/586743002/diff/1/gm/textblobshader.cpp#newcode20
gm/textblobshader.cpp:20: TextBlobShaderGM(const char* txt) {
On 2014/09/19 17:20:26, robertphillips wrote:
> Would it make sense to do any or all of this in onOnceBeforeDraw ?

Done.

https://codereview.chromium.org/586743002/diff/1/src/core/SkDevice.cpp
File src/core/SkDevice.cpp (right):

https://codereview.chromium.org/586743002/diff/1/src/core/SkDevice.cpp#newcod...
src/core/SkDevice.cpp:111: if (paint.getShader()) {
On 2014/09/19 16:47:19, reed1 wrote:
> Tricky, but seems fine for now.
> 
> Perhaps a TODO to consider passing x,y to the other methods, so they could
> handle the additional translate w/o needing to allocate a new shader.

Done.

[f(malita), 2014-09-19 18:35:00]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2014-09-19 18:35:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/586743002/20001

[commit-bot: I haz the power, 2014-09-19 18:40:54]

Committed patchset #2 (id:20001) as 8483326704eff3b6a5fcce3f36d857a9779a4dd2