Run app_shell on Windows.

Run app_shell on Windows.

Remove/ifdef (as appropriate) a few Linux-specific assumptions.

BUG=399363
TEST=app_shell_browsertests

Committed: https://crrev.com/7e5386f556b5a821b2e64264fcdf5a428564abd0
Cr-Commit-Position: refs/heads/master@{#296136}

[Yoyo Zhou, 2014-09-19 01:37:06]

yoz@chromium.org changed reviewers:
+ jamescook@chromium.org

[Yoyo Zhou, 2014-09-19 01:39:07]

The tests actually work! Well, ShellApiTest.Basic, which is the one test that
actually uses app.runtime/app.window.create, seems flaky - I can get it to
timeout locally, sometimes, but not all the time. And I've seen a crash in the
content module in that test, for no discernible reason.

I still need to try running it manually with a sample app.

I filed https://code.google.com/p/chromium/issues/detail?id=415840 for some of
the log spew that comes out of ShellApiTest.Basic.

[James Cook, 2014-09-19 03:06:20]

LGTM!  Exciting.

https://chromiumcodereview.appspot.com/586583002/diff/1/build/all.gyp
File build/all.gyp (right):

https://chromiumcodereview.appspot.com/586583002/diff/1/build/all.gyp#newcode256
build/all.gyp:256: ['chromeos==1 or (OS=="linux" and use_aura==1) or (OS=="win"
and use_aura==1)', {
I don't think you need use_aura in the Windows condition. For the Linux one I'm
not certain -- stock Linux is Aura, Chrome OS is Aura, but there's an "Ozone"
Chrome OS project that I'm not sure if it's Aura or not. It might be worth a try
job run with the conditions removed to see.

https://chromiumcodereview.appspot.com/586583002/diff/1/extensions/shell/app/...
File extensions/shell/app/shell_main_delegate.cc (right):

https://chromiumcodereview.appspot.com/586583002/diff/1/extensions/shell/app/...
extensions/shell/app/shell_main_delegate.cc:95: #endif  // DISABLE_NACL
nit: I wouldn't comment this one, since it's just one line away

https://chromiumcodereview.appspot.com/586583002/diff/1/extensions/shell/brow...
File extensions/shell/browser/shell_nacl_browser_delegate.cc (right):

https://chromiumcodereview.appspot.com/586583002/diff/1/extensions/shell/brow...
extensions/shell/browser/shell_nacl_browser_delegate.cc:90: return
PathService::Get(base::DIR_TEMP, cache_dir);
This at least needs a TODO -- if we ever run app_shell for real on Windows we
probably want the cache directory to be persistent.

[Yoyo Zhou, 2014-09-23 02:01:04]

yoz@chromium.org changed reviewers:
+ ncbray@chromium.org

[Yoyo Zhou, 2014-09-23 02:01:06]

https://chromiumcodereview.appspot.com/586583002/diff/1/build/all.gyp
File build/all.gyp (right):

https://chromiumcodereview.appspot.com/586583002/diff/1/build/all.gyp#newcode256
build/all.gyp:256: ['chromeos==1 or (OS=="linux" and use_aura==1) or (OS=="win"
and use_aura==1)', {
On 2014/09/19 03:06:20, James Cook wrote:
> I don't think you need use_aura in the Windows condition. For the Linux one
I'm
> not certain -- stock Linux is Aura, Chrome OS is Aura, but there's an "Ozone"
> Chrome OS project that I'm not sure if it's Aura or not. It might be worth a
try
> job run with the conditions removed to see.

Done.

https://chromiumcodereview.appspot.com/586583002/diff/1/extensions/shell/brow...
File extensions/shell/browser/shell_nacl_browser_delegate.cc (right):

https://chromiumcodereview.appspot.com/586583002/diff/1/extensions/shell/brow...
extensions/shell/browser/shell_nacl_browser_delegate.cc:90: return
PathService::Get(base::DIR_TEMP, cache_dir);
On 2014/09/19 03:06:20, James Cook wrote:
> This at least needs a TODO -- if we ever run app_shell for real on Windows we
> probably want the cache directory to be persistent.

Added a TODO.

ncbray: any suggestions?

[Yoyo Zhou, 2014-09-23 02:03:28]

The CQ bit was checked by yoz@chromium.org

[commit-bot: I haz the power, 2014-09-23 02:04:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/586583002/20001

[commit-bot: I haz the power, 2014-09-23 03:00:57]

Committed patchset #2 (id:20001) as c6ba0c88565e6fcbe780fbdea6f30f4d08ad064b

[commit-bot: I haz the power, 2014-09-23 03:01:36]

Patchset 2 (id:??) landed as
https://crrev.com/7e5386f556b5a821b2e64264fcdf5a428564abd0
Cr-Commit-Position: refs/heads/master@{#296136}