Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: extensions/shell/browser/shell_nacl_browser_delegate.cc

Issue 586583002: Run app_shell on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: jamescook Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/shell/app_shell.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/shell/browser/shell_nacl_browser_delegate.cc
diff --git a/extensions/shell/browser/shell_nacl_browser_delegate.cc b/extensions/shell/browser/shell_nacl_browser_delegate.cc
index 778763b0b4b6c14b56a023f23b83bee1ed48ae85..668c3d8a23e47c897590658a002c4eda210d3a81 100644
--- a/extensions/shell/browser/shell_nacl_browser_delegate.cc
+++ b/extensions/shell/browser/shell_nacl_browser_delegate.cc
@@ -6,6 +6,7 @@
#include <string>
+#include "base/base_paths.h"
#include "base/command_line.h"
#include "base/path_service.h"
#include "base/strings/string_split.h"
@@ -83,7 +84,12 @@ bool ShellNaClBrowserDelegate::DialogsAreSuppressed() {
bool ShellNaClBrowserDelegate::GetCacheDirectory(base::FilePath* cache_dir) {
// Just use the general cache directory, not a subdirectory like Chrome does.
+#if defined(OS_POSIX)
return PathService::Get(base::DIR_CACHE, cache_dir);
+#elif defined(OS_WIN)
+ // TODO(yoz): Find an appropriate persistent directory to use here.
+ return PathService::Get(base::DIR_TEMP, cache_dir);
+#endif
}
bool ShellNaClBrowserDelegate::GetPluginDirectory(base::FilePath* plugin_dir) {
« no previous file with comments | « extensions/shell/app_shell.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698