[I-Spy] Add utilities to help manage expectations that track Chrome versions.

[I-Spy] Add utilities to help manage expectations that track Chrome versions.

BUG=297210
TEST=included
NOTRY=True

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233436

[frankf, 2013-11-04 23:42:49]

I can't really review this without a design doc outlining how expectations work,
and how ispy is extendible

[craigdh, 2013-11-05 00:06:34]

On 2013/11/04 23:42:49, frankf wrote:
> I can't really review this without a design doc outlining how expectations
work,
> and how ispy is extendible

This doesn't "extend" I-Spy, it is almost entirely separate from I-Spy, it is
mainly string manipulation to track the chrome version. This change treats I-Spy
and expectations as a black box, I don't see how a design doc for them would
help.

The two calls to the I-Spy API are code that you already reviewed twice in
run_popular_urls_test, it's just being factored out here. You can get the
documentation for them by running "pydoc ispy_utils" but the usage should be
clear from the context.

[frankf, 2013-11-05 00:22:01]

On 2013/11/05 00:06:34, craigdh wrote:
> On 2013/11/04 23:42:49, frankf wrote:
> > I can't really review this without a design doc outlining how expectations
> work,
> > and how ispy is extendible
> 
> This doesn't "extend" I-Spy, it is almost entirely separate from I-Spy, it is
> mainly string manipulation to track the chrome version. This change treats
I-Spy
> and expectations as a black box, I don't see how a design doc for them would
> help.
> 
> The two calls to the I-Spy API are code that you already reviewed twice in
> run_popular_urls_test, it's just being factored out here. You can get the
> documentation for them by running "pydoc ispy_utils" but the usage should be
> clear from the context.

This is the only design doc for this entire project which is out-dated and
provides no details:
https://docs.google.com/a/google.com/document/d/18Oh29qUSneDIync_6oa6ywyarRIM...

It's not clear to the me (reviewer) why these utils are separated from i-spy,
and I don't see a notion of device type. I can
probably figure it looking hard enough at the code, but it's up the CL author to
clarify intent and where this is headed :)

[craigdh, 2013-11-05 17:20:52]

I-Spy User Guide:
https://docs.google.com/a/google.com/document/d/1SsIpMcqaBBA8v_0riZjh9EpcMHO-...

Please comment in the doc if there are any areas that are still unclear.

[craigdh, 2013-11-06 18:33:18]

On 2013/11/05 17:20:52, craigdh wrote:
> I-Spy User Guide:
>
https://docs.google.com/a/google.com/document/d/1SsIpMcqaBBA8v_0riZjh9EpcMHO-...
> 
> Please comment in the doc if there are any areas that are still unclear.

ping?

[frankf, 2013-11-06 23:06:40]

https://codereview.chromium.org/58623002/diff/70001/chrome/test/functional/is...
File chrome/test/functional/ispy/client/chrome_utils.py (right):

https://codereview.chromium.org/58623002/diff/70001/chrome/test/functional/is...
chrome/test/functional/ispy/client/chrome_utils.py:38: """Updates the most
recent expectation version to the Chrome version.
As discussed offline: just make device/url first class parameters and usse
python dis utils for loose version comparison

[craigdh, 2013-11-06 23:41:07]

https://codereview.chromium.org/58623002/diff/70001/chrome/test/functional/is...
File chrome/test/functional/ispy/client/chrome_utils.py (right):

https://codereview.chromium.org/58623002/diff/70001/chrome/test/functional/is...
chrome/test/functional/ispy/client/chrome_utils.py:38: """Updates the most
recent expectation version to the Chrome version.
On 2013/11/06 23:06:40, frankf wrote:
> As discussed offline: just make device/url first class parameters and usse
> python dis utils for loose version comparison

Done.

[frankf, 2013-11-06 23:47:26]

https://codereview.chromium.org/58623002/diff/140001/chrome/test/functional/i...
File chrome/test/functional/ispy/client/chrome_utils.py (right):

https://codereview.chromium.org/58623002/diff/140001/chrome/test/functional/i...
chrome/test/functional/ispy/client/chrome_utils.py:105: """Create the full
expectation name from the expectation and version.
Provide examples for all args and return value

[craigdh, 2013-11-07 00:06:15]

https://codereview.chromium.org/58623002/diff/140001/chrome/test/functional/i...
File chrome/test/functional/ispy/client/chrome_utils.py (right):

https://codereview.chromium.org/58623002/diff/140001/chrome/test/functional/i...
chrome/test/functional/ispy/client/chrome_utils.py:105: """Create the full
expectation name from the expectation and version.
On 2013/11/06 23:47:26, frankf wrote:
> Provide examples for all args and return value

Done.

[frankf, 2013-11-07 00:11:36]

lgtm

[commit-bot: I haz the power, 2013-11-07 00:29:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/craigdh@chromium.org/58623002/180001

[commit-bot: I haz the power, 2013-11-07 00:32:03]

Change committed as 233436