Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Unified Diff: chrome/test/functional/ispy/common/ispy_utils.py

Issue 58623002: [I-Spy] Add utilities to help manage expectations that track Chrome versions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nit: slight changes to a docstring Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/functional/ispy/common/ispy_utils.py
diff --git a/chrome/test/functional/ispy/common/ispy_utils.py b/chrome/test/functional/ispy/common/ispy_utils.py
index 10669513f022bdbfbf3535fda28ea1fbfab7d246..6fa7d08fe33f66e3ee9a66a17b6550271153594d 100644
--- a/chrome/test/functional/ispy/common/ispy_utils.py
+++ b/chrome/test/functional/ispy/common/ispy_utils.py
@@ -86,7 +86,7 @@ class ISpyUtils(object):
self.cloud_bucket.UpdateFile(full_path, image_tools.EncodePNG(image))
- def UploadExpectation(self, expectation, images):
+ def GenerateExpectation(self, expectation, images):
"""Creates and uploads an expectation to GS from a set of images and name.
This method generates a mask from the uploaded images, then
@@ -102,7 +102,7 @@ class ISpyUtils(object):
GetExpectationPath(expectation, 'expected.png'), images[0])
self.UploadImage(GetExpectationPath(expectation, 'mask.png'), mask)
- def RunTest(self, test_run, expectation, actual):
+ def PerformComparison(self, test_run, expectation, actual):
"""Runs an image comparison, and uploads discrepancies to GS.
Args:
@@ -190,7 +190,7 @@ class ISpyUtils(object):
for path in test_paths:
self.cloud_bucket.RemoveFile(path)
- def UploadExpectationPinkOut(self, expectation, images, pint_out, rgb):
+ def GenerateExpectationPinkOut(self, expectation, images, pint_out, rgb):
"""Uploads an ispy-test to GS with the pink_out workaround.
Args:
« no previous file with comments | « chrome/test/functional/ispy/client/chrome_utils_unittest.py ('k') | chrome/test/functional/ispy/common/ispy_utils_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698