Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Unified Diff: sdk/lib/_internal/pub/test/global/binstubs/binstub_runs_precompiled_snapshot_test.dart

Issue 586173002: Make binstubs run snapshots directly when possible. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Revise! Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/test/global/binstubs/binstub_runs_precompiled_snapshot_test.dart
diff --git a/sdk/lib/_internal/pub/test/global/binstubs/removes_when_deactivated_test.dart b/sdk/lib/_internal/pub/test/global/binstubs/binstub_runs_precompiled_snapshot_test.dart
similarity index 66%
copy from sdk/lib/_internal/pub/test/global/binstubs/removes_when_deactivated_test.dart
copy to sdk/lib/_internal/pub/test/global/binstubs/binstub_runs_precompiled_snapshot_test.dart
index 3a8e149c588a0abb056a3d4091105dfc803f9e82..cc2491155ebf24597df69bba625008864a0f3b0f 100644
--- a/sdk/lib/_internal/pub/test/global/binstubs/removes_when_deactivated_test.dart
+++ b/sdk/lib/_internal/pub/test/global/binstubs/binstub_runs_precompiled_snapshot_test.dart
@@ -9,28 +9,24 @@ import '../../test_pub.dart';
main() {
initConfig();
- integration("removes binstubs when the package is deactivated", () {
+ integration("the binstubs runs a precompiled snapshot if present", () {
servePackages((builder) {
builder.serve("foo", "1.0.0", pubspec: {
"executables": {
- "one": null,
- "two": null
+ "foo-script": "script"
}
}, contents: [
d.dir("bin", [
- d.file("one.dart", "main(args) => print('one');"),
- d.file("two.dart", "main(args) => print('two');")
+ d.file("script.dart", "main(args) => print('ok');")
])
]);
});
schedulePub(args: ["global", "activate", "foo"]);
- schedulePub(args: ["global", "deactivate", "foo"]);
d.dir(cachePath, [
d.dir("bin", [
- d.nothing("one"),
- d.nothing("two")
+ d.matcherFile("foo-script", contains("script.dart.snapshot"))
])
]).validate();
});

Powered by Google App Engine
This is Rietveld 408576698