Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Unified Diff: sdk/lib/_internal/pub/test/global/binstubs/binstub_runs_global_run_if_no_snapshot_test.dart

Issue 586173002: Make binstubs run snapshots directly when possible. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Revise! Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/test/global/binstubs/binstub_runs_global_run_if_no_snapshot_test.dart
diff --git a/sdk/lib/_internal/pub/test/global/binstubs/path_package_test.dart b/sdk/lib/_internal/pub/test/global/binstubs/binstub_runs_global_run_if_no_snapshot_test.dart
similarity index 64%
copy from sdk/lib/_internal/pub/test/global/binstubs/path_package_test.dart
copy to sdk/lib/_internal/pub/test/global/binstubs/binstub_runs_global_run_if_no_snapshot_test.dart
index a837f73a9b95c1421860d8273db493073bfc1771..da72ec3fb0741c86dc69ab4c6785f5185396667e 100644
--- a/sdk/lib/_internal/pub/test/global/binstubs/path_package_test.dart
+++ b/sdk/lib/_internal/pub/test/global/binstubs/binstub_runs_global_run_if_no_snapshot_test.dart
@@ -9,25 +9,26 @@ import '../../test_pub.dart';
main() {
initConfig();
- integration("creates binstubs when activating a path package", () {
+ integration("the binstubs runs pub global run if there is no snapshot", () {
d.dir("foo", [
d.pubspec({
"name": "foo",
"executables": {
- "foo": null
+ "foo-script": "script"
}
}),
d.dir("bin", [
- d.file("foo.dart", "main() => print('ok');")
+ d.file("script.dart", "main() => print('ok');")
])
]).create();
+ // Path packages are mutable, so no snapshot is created.
schedulePub(args: ["global", "activate", "--source", "path", "../foo"],
- output: contains("Installed executable foo."));
+ output: contains("Installed executable foo-script."));
d.dir(cachePath, [
d.dir("bin", [
- d.matcherFile("foo", contains("pub global run foo:foo"))
+ d.matcherFile("foo-script", contains("pub global run foo:script"))
])
]).validate();
});

Powered by Google App Engine
This is Rietveld 408576698