10.6 runtime compatibility for ProcessReader and MachOImageReader test

10.6 runtime compatibility for ProcessReader.

On 10.6, the main executable does not show up at index 0, but appears
elsewhere in the list. Modules are now scanned to ensure that the
MH_EXECUTE one is first in the list. This means that ProcessReader is
now responsible for creating a MachOImageReader object for each module,
rather than having its callers perform that task.

TEST=util_test MachOImageReader.*:ProcessReader.*
R=rsesek@chromium.org

Committed: https://chromium.googlesource.com/crashpad/crashpad/+/8e70083aa030a1a89590d906d2402771b23de570

[Mark Mentovai, 2014-09-19 20:33:18]

mark@chromium.org changed reviewers:
+ rsesek@chromium.org

[Mark Mentovai, 2014-09-21 18:50:11]

Patchset #2 (id:20001) has been deleted

[Mark Mentovai, 2014-09-22 03:46:03]

I split the MachOImageReader test portion out into its own change at
https://codereview.chromium.org/586393003.

[Robert Sesek, 2014-09-22 16:31:41]

LGTM

https://codereview.chromium.org/586123002/diff/60001/util/mac/process_reader.cc
File util/mac/process_reader.cc (right):

https://codereview.chromium.org/586123002/diff/60001/util/mac/process_reader....
util/mac/process_reader.cc:517: this, all_image_infos.dyldImageLoadAddress,
module_name)) {
nit: indent +4

[Mark Mentovai, 2014-09-22 17:09:02]

Committed patchset #4 (id:80001) manually as 8e70083 (presubmit successful).