Issue 586393003: 10.6 runtime compatibility for MachOImageReader test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 586393003: 10.6 runtime compatibility for MachOImageReader test (Closed)

Created:
6 years, 3 months ago by Mark Mentovai

Modified:
6 years, 3 months ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Project:
crashpad

Visibility:
Public.

More Reviews

Description

10.6 runtime compatibility for MachOImageReader test. Don’t require a __TEXT, __text section in every module. Some system modules on 10.6, including ApplicationServices, do not have this section. This change does not consider the runtime OS version. Split from https://codereview.chromium.org/586123002/. TEST=util_test MachOImageReader.* R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/32ed4b367dd82497a3a5569cef80c114e27adf1d

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address review feedback #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -8 lines)			Patch
	M	util/mac/mach_o_image_reader_test.cc	View	1	4 chunks	+35 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Robert Sesek

LGTM https://codereview.chromium.org/586393003/diff/1/util/mac/mach_o_image_reader_test.cc File util/mac/mach_o_image_reader_test.cc (right): https://codereview.chromium.org/586393003/diff/1/util/mac/mach_o_image_reader_test.cc#newcode300 util/mac/mach_o_image_reader_test.cc:300: SEG_TEXT) { nit: indent +4

6 years, 3 months ago (2014-09-22 16:35:47 UTC) #3

Mark Mentovai

6 years, 3 months ago (2014-09-22 17:10:23 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 32ed4b3 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages