Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 586053003: Remove PagePopup runtime flag (status=stable) for chromium (Closed)

Created:
6 years, 3 months ago by heeyoun.lee
Modified:
6 years, 2 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, eseidel, kangil_, pdr., tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove PagePopup runtime flag (status=stable) for chromium BUG=402536 Committed: https://crrev.com/a0a8313cd7d7ae41ebd07c5fcba0c8659613fb87 Cr-Commit-Position: refs/heads/master@{#298665}

Patch Set 1 #

Patch Set 2 : fix for commit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M content/child/runtime_features.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
heeyoun.lee
This is for chromium. PTAL blink : https://codereview.chromium.org/594033002/
6 years, 3 months ago (2014-09-23 07:22:58 UTC) #2
Avi (use Gerrit)
lgtm
6 years, 3 months ago (2014-09-23 14:10:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/586053003/1
6 years, 3 months ago (2014-09-25 05:55:08 UTC) #5
commit-bot: I haz the power
Failed to apply patch for content/child/runtime_features.cc: While running git apply --index -3 -p1; error: patch ...
6 years, 3 months ago (2014-09-25 07:04:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/586053003/20001
6 years, 2 months ago (2014-10-08 05:02:13 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 25a05d96fb868c4eff04e3540be1299c953e7bd7
6 years, 2 months ago (2014-10-08 06:48:55 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/a0a8313cd7d7ae41ebd07c5fcba0c8659613fb87 Cr-Commit-Position: refs/heads/master@{#298665}
6 years, 2 months ago (2014-10-08 06:50:13 UTC) #11
tkent
Please don't do this. The flag must be false on Android.
6 years, 2 months ago (2014-10-08 07:31:30 UTC) #12
tkent
6 years, 2 months ago (2014-10-08 07:43:21 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/641563002/ by tkent@chromium.org.

The reason for reverting is: Broke <input type=color> UI on Android.
.

Powered by Google App Engine
This is Rietveld 408576698