chrome/browser/cocoa/location_bar_view_mac.mm - Issue 586009: [Mac] Fix use-after-free when dragging tabs with page-actions....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/cocoa/location_bar_view_mac.mm

Issue 586009: [Mac] Fix use-after-free when dragging tabs with page-actions.... (Closed) Base URL: svn://svn.chromium.org/chrome/branches/307/src/

Patch Set: Created 10 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/cocoa/location_bar_view_mac.mm

===================================================================

--- chrome/browser/cocoa/location_bar_view_mac.mm (revision 38373)

+++ chrome/browser/cocoa/location_bar_view_mac.mm (working copy)

@@ -106,6 +106,11 @@

}

LocationBarViewMac::~LocationBarViewMac() {

+ // Disconnect from cell in case it outlives us.

+ AutocompleteTextFieldCell* cell = [field_ autocompleteTextFieldCell];

+ [cell setPageActionViewList:NULL];

+ [cell setSecurityImageView:NULL];

// TODO(shess): Placeholder for omnibox changes.

delete page_action_views_;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »