Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 586009: [Mac] Fix use-after-free when dragging tabs with page-actions.... (Closed)

Created:
10 years, 10 months ago by Scott Hess - ex-Googler
Modified:
9 years, 6 months ago
CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

[Mac] Fix use-after-free when dragging tabs with page-actions. This patches in the relevant bit of r38299: http://src.chromium.org/viewvc/chrome?view=rev&revision=38299 > When dragging and dropping a tab who's window is going away entirely, > the LocationBarViewMac instance and the PageActionViewList w/in go > away before the cell. Sometimes windows can re-display while being > closed, then BANG. BUG=34110 TEST=Install an extension which shows a page action (*). Bring up two tabs, drag one with the page action off to a separate window. Drag it back into the first window. (*) For instance, the "Subscribe in Feed Reader" example at http://code.google.com/chrome/extensions/samples.html , then browse to Google News to get a page action. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=38400

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/cocoa/location_bar_view_mac.mm View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Scott Hess - ex-Googler
The original CL doesn't drover at all well due to conflicts, so this just patches ...
10 years, 10 months ago (2010-02-08 20:52:55 UTC) #1
Scott Hess - ex-Googler
On 2010/02/08 20:52:55, shess wrote: > The original CL doesn't drover at all well due ...
10 years, 10 months ago (2010-02-08 21:00:01 UTC) #2
Pam (message me for reviews)
10 years, 10 months ago (2010-02-08 21:41:28 UTC) #3
LGTM.

- Pam

Powered by Google App Engine
This is Rietveld 408576698